• Introducing XDA Computing: Discussion zones for Hardware, Software, and more!    Check it out!

[MOD][2018-09-23] OnePlus Camera M

Search This thread

txx1219

Senior Member
Jan 29, 2011
211
1,159
kX9Bej.png


For OP5/5T thread, click here

Don't hesitate to post your settings, samples and comparisons !

Before installing

If you have installed an update of Oneplus Camera before, you have to understand that the update is "above" the original system application. Because my mod replace the original system application, you will never see a difference because the current app will be the updated app and not the system app.
To remove the update, go into the App Info of Oneplus Camera, press the tree dots in the top right and press "Uninstall Updates".


Changelog
Code:
[B]2018-09-23[/B]
- Based on 2.8.20 (New UI design and others improvements)
- Fix issue of wrong orientation
- Compatible with Android 8.1 and 9

[B]2018-08-12 TEST [/B]
- First release
- Based on new version 2.7.3
- Possibility to control sharpness post-applied
- Possibility to control noise reduction
- Only working on OP6 ! I don't have made a version compatible both for OP5 and OP6 yet.
- This is a test version. I hope everyone plays with options available to find out bests configurations at certain conditions (bright light, mid-light and low-light). I can after that define a pattern to be applied according to what you decide.


Downloads
Magisk Module
Older (2018-08-12 TEST)

Big credits for
@Arnova8G2 , massive thanks for helping me understand better Camera2 API and motivates me to do all this. Without him, this mod would be not here today.
@DorianX for finding solution to get Panorama working
 
Last edited:

deezid

Senior Member
Jun 26, 2010
966
209
Viersen
WHOA
My biggest issue on the OP6 camera is the heavy oversharpening and too much noise reduction (aka water color effect). I rather have a little bit of grain like Gcam does while showing way more fine detail and texture.

Let's see what this one does.
Please add a saturation, tint (the OP6 is quite on the magenta side) and contrast slider if possible
Will do some tests and comparisons tomorrow.

---------- Post added at 10:34 PM ---------- Previous post was at 10:14 PM ----------

My first observations:
Edge sharpening off doesn't mean sharpening is off. The picture is a bit cleaner already though - no more oil-painting effect. I wish it would be possible to dial it down even further though.
Noise reduction off means that chroma reduction still works the same but luma noise reduction is greatly reduced. Way more detail but also some film-like grain. Fast and minimal cause too much of a detail and texture loss. Off is perfect in terms of detail, but lots of noise. Is it possible to have something in-between?
The picture output is way closer to gcam!

Thanks for the mod! @txx1219
Will keep me from using gcam in many situations.
 
Last edited:

ajsmsg78

Senior Member
Dec 6, 2008
5,167
4,618
Selden, NY
Huawei MediaPad X2
Huawei Mate 9
WHOA
My biggest issue on the OP6 camera is the heavy oversharpening and too much noise reduction (aka water color effect). I rather have a little bit of grain like Gcam does while showing way more fine detail and texture.

Let's see what this one does.
Please add a saturation, tint (the OP6 is quite on the magenta side) and contrast slider if possible
Will do some tests and comparisons tomorrow.

---------- Post added at 10:34 PM ---------- Previous post was at 10:14 PM ----------

My first observations:
Edge sharpening off doesn't mean sharpening is off. The picture is a bit cleaner already though - no more oil-painting effect. I wish it would be possible to dial it down even further though.
Noise reduction off means that chroma reduction still works the same but luma noise reduction is greatly reduced. Way more detail but also some film-like grain. Fast and minimal cause too much of a detail and texture loss. Off is perfect in terms of detail, but lots of noise. Is it possible to have something in-between?
The picture output is way closer to gcam!

Thanks for the mod! @txx1219
Will keep me from using gcam in many situations.

What I don't like about the stock cam is that it's never sharp enough and always tries to smooth everything out which I hate. It would be nice to have the pic process exactly the way it is shown in the viewfinder before you take it. The Google Camera's that we have are much sharper but have too many other bugs. This camera M doesn't really take good quality photos. It's similar quality to the ones on the older builds of Lineage custom roms before the camera fixes were applied.
 
Last edited:
  • Like
Reactions: jonny30bass

deezid

Senior Member
Jun 26, 2010
966
209
Viersen
Daylight conclusions
ZSL for both sharpening and nr (standard OP6 setting) creates painting like photos. There's almost no more detail on the gray bricks left.
https://drive.google.com/file/d/1Op3vP0OxTQ-qpW1Lzj6E7jYtzx0ax0i5qw/view?usp=sharing

Both set to off creates a very unprocessed looking image, perfect for further editing with good detail.
https://drive.google.com/file/d/1uOpKS5Foz5Rd6llKZYcVckuPqRncCgUr-g/view?usp=sharing

A good compromise for a ready to go but not as overprocessed image with still lots of texture left on the bricks, no watercolor effect either, just some sharpening halos
https://drive.google.com/file/d/1aHS1_Nvd6V3EO_V76AseTPPy32gHPuJsug/view?usp=sharing

Insane amount of texture is there when using sharpening set to fast and nr set to off, for people who like it gritty:
https://drive.google.com/file/d/1xffl73yv2vuWca074JlG1YvWfsisVPAHWA/view?usp=sharing

sorry for the changing light conditions, shouldn't affect the cameras' performance though.


Question:
Is it possible to further reduce sharpening and nr than "fast". Something between "Off" and "fast" would be amazing.
 
Last edited:

daleski75

Senior Member
Jul 21, 2008
5,762
6,464
Northampton
Xiaomi Mi 11
Google Pixel 6 Pro
Daylight conclusions
ZSL for both sharpening and nr (standard OP6 setting) creates painting like photos. There's almost no more detail on the gray bricks left.
https://drive.google.com/file/d/1Op3vP0OxTQ-qpW1Lzj6E7jYtzx0ax0i5qw/view?usp=sharing

Both set to off creates a very unprocessed looking image, perfect for further editing with good detail.
https://drive.google.com/file/d/1uOpKS5Foz5Rd6llKZYcVckuPqRncCgUr-g/view?usp=sharing

A good compromise for a ready to go but not as overprocessed image with still lots of texture left on the bricks, no watercolor effect either, just some sharpening halos
https://drive.google.com/file/d/1aHS1_Nvd6V3EO_V76AseTPPy32gHPuJsug/view?usp=sharing

Insane amount of texture is there when using sharpening set to fast and nr set to off, for people who like it gritty:
https://drive.google.com/file/d/1xffl73yv2vuWca074JlG1YvWfsisVPAHWA/view?usp=sharing

sorry for the changing light conditions, shouldn't affect the cameras' performance though.


Question:
Is it possible to further reduce sharpening and nr than "fast". Something between "Off" and "fast" would be amazing.


Really good photos and nice garden too :)

The amount of detail missing between the 1st photo and the last photo is shocking, for me personally fast+no nr is the best option by far.
 
Last edited:

txx1219

Senior Member
Jan 29, 2011
211
1,159
Daylight conclusions
ZSL for both sharpening and nr (standard OP6 setting) creates painting like photos. There's almost no more detail on the gray bricks left.
https://drive.google.com/file/d/1Op3vP0OxTQ-qpW1Lzj6E7jYtzx0ax0i5qw/view?usp=sharing

Both set to off creates a very unprocessed looking image, perfect for further editing with good detail.
https://drive.google.com/file/d/1uOpKS5Foz5Rd6llKZYcVckuPqRncCgUr-g/view?usp=sharing

A good compromise for a ready to go but not as overprocessed image with still lots of texture left on the bricks, no watercolor effect either, just some sharpening halos
https://drive.google.com/file/d/1aHS1_Nvd6V3EO_V76AseTPPy32gHPuJsug/view?usp=sharing

Insane amount of texture is there when using sharpening set to fast and nr set to off, for people who like it gritty:
https://drive.google.com/file/d/1xffl73yv2vuWca074JlG1YvWfsisVPAHWA/view?usp=sharing

sorry for the changing light conditions, shouldn't affect the cameras' performance though.


Question:
Is it possible to further reduce sharpening and nr than "fast". Something between "Off" and "fast" would be amazing.


That's the issue, there is no options between off and fast.
I'm glad to see that we have the same conclusion : Fast - Fast is the best compromise at the moment.
Also, avoid as much the ZSL - ZSL combination because it produces a lot of oil-painting inconsistent pictures.

My recommandations at the moment are Fast-Fast on good light condition and HQ - HQ on low light condition.
 
  • Like
Reactions: hurray and deezid

deezid

Senior Member
Jun 26, 2010
966
209
Viersen
That's the issue, there is no options between off and fast.
I'm glad to see that we have the same conclusion : Fast - Fast is the best compromise at the moment.
Also, avoid as much the ZSL - ZSL combination because it produces a lot of oil-painting inconsistent pictures.

My recommandations at the moment are Fast-Fast on good light condition and HQ - HQ on low light condition.
Pity, really hoped there was something in-between. Maybe let the camera 2 versions (off/fast) at the same time and combine them at 50/50. lol

Sent from my ONEPLUS A6003 using Tapatalk
 

Top Liked Posts