• XDA Forums have been migrated to XenForo. We are aware of several issues including missing threads, logins not working, and more. To discuss, use this thread.

[MOD][Camera][Lib] Front Camera HDR+ Fix

defcomg

New member
Dec 10, 2006
3,852
3,297
0
30
Last edited:

rrusl1

New member
Dec 5, 2014
48
19
0
Im already making an backup , ill give my feedback after install! thank you for your work in advance !!!!

---------- Post added at 01:09 AM ---------- Previous post was at 12:48 AM ----------

Im already making an backup , ill give my feedback after install! thank you for your work in advance !!!!
i mae an backup , then wiped cache/dalvik - then installed gcam , then fix ,- reboot

Fix woked , but HDR+ is working only when portrait mode is on , and photos are very "Blured" , but still its amazing progresss , thank you very much for this !!!!

---------- Post added at 01:44 AM ---------- Previous post was at 01:09 AM ----------

Ok , for all front cam features working u will need :

1.This vers of gcam https://www.celsoazevedo.com/files/android/google-camera/f/changelog40/

2.Those settings -
 
Last edited:

rdNNNN

New member
Dec 21, 2014
93
87
0
@defcomg

It's good to have you working a little for our device. Thanks for the impressive work!

Since you seem to be the only dev with deep knowledge on android camera libs, I would like to hear your opinion on this issue.
Camera2 API Bugs
It has been reported counteless times, I've myself tweeted oneplus and carl pei about the issue, but nothing official ever came out.

There are two big issues right now. The crash described in that post under certain conditions (which also makes Gcam crash wheen shooting bright light using some of the hdr+ enhanced profiles;
The second one actually brokes the third party manual camera experience. IF you shoot under camera2 api using full auto, photos will come right (as gcam can do), even when using ISO above 799 (auto picked from software). Once you try manual controls, iso inputs above 799 will be the same as 799. What does it mean? We actually can't use a third party camera like filmic pro or cinema4k under low light settings or we can't use more advanced photo cams, like camera fv-5, to shoot low light with manual controls (which have some extras that stock cam lacks like the intervalometer).

Let me say again. Don't read this as a request. We just would love to have a word if it can be easily fixable, or even fixable, by someone who might have the time to spend.
Thanks again, and sorry for the little off-topic.
 

defcomg

New member
Dec 10, 2006
3,852
3,297
0
30
@defcomg

It's good to have you working a little for our device. Thanks for the impressive work!

Since you seem to be the only dev with deep knowledge on android camera libs, I would like to hear your opinion on this issue.
Camera2 API Bugs
It has been reported counteless times, I've myself tweeted oneplus and carl pei about the issue, but nothing official ever came out.

There are two big issues right now. The crash described in that post under certain conditions (which also makes Gcam crash wheen shooting bright light using some of the hdr+ enhanced profiles;
The second one actually brokes the third party manual camera experience. IF you shoot under camera2 api using full auto, photos will come right (as gcam can do), even when using ISO above 799 (auto picked from software). Once you try manual controls, iso inputs above 799 will be the same as 799. What does it mean? We actually can't use a third party camera like filmic pro or cinema4k under low light settings or we can't use more advanced photo cams, like camera fv-5, to shoot low light with manual controls (which have some extras that stock cam lacks like the intervalometer).

Let me say again. Don't read this as a request. We just would love to have a word if it can be easily fixable, or even fixable, by someone who might have the time to spend.
Thanks again, and sorry for the little off-topic.
Hmm this might need logs but you can do this
Add these to build.prop

persist.camera.cafscan=5 persist.camera.hal.debug=5 persist.camera.q3a.debug=5 persist.camera.sensor.debug=5 persist.camera.stats.aec.debug=5 persist.camera.stats.q3a.debug=5

Reboot

Download Terminal Emulator from playstore

Type su
Then Type dumpsys media.camera > /sdcard/opcam.txt

Then from /vendor/lib/libmmcamera_imx298**.so

Attach those files as well logcat after using the camera with described I'll see I can do anything
 

Hubaqu

New member
Feb 24, 2012
183
72
0
Madeira
Test Fix for the Op5/5T

FRONTCAM_PORTRAIT_FIX_OP5T.zip - Magisk

Hi, as reported getting the purple tint when taking pictures on front cam with or without HDR+.
Here I send you the logs when entering the app and taking a pic with HDR+ on.
Apk Used: MGC_5.1.018.177470874.41362666__A7.0-8.1_MI5S_v2e.apk

I send 2 pics to show HDR+ is actually working.
 

Attachments

  • Like
Reactions: zoneofSAM

lostdiamond

New member
Sep 21, 2010
18
0
0
I tried installing the magisk module but I am getting error 2 ( using Z-Unleashed, 8.1, TWRP 3.2.1), any guidance will be greatly appreciated.
Thanks for the awesome work.
 
Our Apps
Get our official app! (coming soon)
The best way to access XDA on your phone
Nav Gestures
Add swipe gestures to any Android
One Handed Mode
Eases uses one hand with your phone