[MODULE] SafetyPatcher

Did it work?


  • Total voters
    345

Depau

Senior Member
Mar 16, 2013
209
144
0
Milan, Italy
depau.eu
I tried running the magisk module and it didn't change the status (i.e. /proc/cmdline still shows "orange"). Have you checked Lineage toybox's sed doesn't do anything weird?

Running Lineage OS 15.1 on OnePlus 3T, Magisk 16
 

hackintosh5

Senior Member
Sep 15, 2017
1,246
947
0
I tried running the magisk module and it didn't change the status (i.e. /proc/cmdline still shows "orange"). Have you checked Lineage toybox's sed doesn't do anything weird?

Running Lineage OS 15.1 on OnePlus 3T, Magisk 16
What version of the module is in use? Does /proc/cmdline show 'orange' or 'ORANGE'? Is it different in /data/local/tmp/cmdline?

I'm running LineageOS myself, the toybox seems ok. However, despite the lack of a device with lowercase orange to test on, I was able to manually test the sed toybox, and it worked case-insensitively, which is how it should.

I think there may be a problem in your end, so I need the magisk logs and the contents of /data/local/tmp/cmdline

Sent from my kminiltexx using XDA Labs
 

hell0

Member
May 5, 2010
14
0
21
on Xiaomi A1 stock 8.1 August patch level, Magisk 16.0, this module didn't work, editing post-fs-data.sh to use lower case DID work.. either make the script run twice with both versions or check which one it is?
default for my device was lower case, /proc/cmdline showed 'orange'
Thanks for your work!
 

hackintosh5

Senior Member
Sep 15, 2017
1,246
947
0
on Xiaomi A1 stock 8.1 August patch level, Magisk 16.0, this module didn't work, editing post-fs-data.sh to use lower case DID work.. either make the script run twice with both versions or check which one it is?
default for my device was lower case, /proc/cmdline showed 'orange'
Thanks for your work!
Which version of the module are you using? I recently updated it to use case-insensitive matching

Sent from my kminiltexx using XDA Labs
 

jbradshw

Senior Member
Dec 8, 2010
170
14
38
Atlanta
So I thought I would give this a try since basicIntegrity is failing in Magisk Manager. It's always failed for quite awhile now - I'm just finally getting around to fixing it. Once this is fixed I'll move on to the CTS failing.

LineageOS 15.1-20180629-UNOFFICIAL-potter
AceKernel v1.14
Magisk 17.1

For starters, I disabled all of the Magisk modules and it's still failing. I verified Magiskhide is working by installing RootBeer and hiding it. It thinks my phone is not rooted so we're good to go on that.

I re-enabled the modules (Magisk Manager for Recovery Mode being one of them) and then installed this module but I'm still getting a failure on basicIntegrity after reboot.
 

hackintosh5

Senior Member
Sep 15, 2017
1,246
947
0
So I thought I would give this a try since basicIntegrity is failing in Magisk Manager. It's always failed for quite awhile now - I'm just finally getting around to fixing it. Once this is fixed I'll move on to the CTS failing.

LineageOS 15.1-20180629-UNOFFICIAL-potter
AceKernel v1.14
Magisk 17.1

For starters, I disabled all of the Magisk modules and it's still failing. I verified Magiskhide is working by installing RootBeer and hiding it. It thinks my phone is not rooted so we're good to go on that.

I re-enabled the modules (Magisk Manager for Recovery Mode being one of them) and then installed this module but I'm still getting a failure on basicIntegrity after reboot.
Please grab /proc/cmdline. If it has the word 'orange' then also get the magisk logs and /data/local/tmp/cmdline.

If, in /proc/cmdline, it's green, this module is functioning correctly and some other aspect of your system is detected by safetynet.

Sent from my kminiltexx using XDA Labs
 

jbradshw

Senior Member
Dec 8, 2010
170
14
38
Atlanta
Please grab /proc/cmdline. If it has the word 'orange' then also get the magisk logs and /data/local/tmp/cmdline.

If, in /proc/cmdline, it's green, this module is functioning correctly and some other aspect of your system is detected by safetynet.

Sent from my kminiltexx using XDA Labs
I don't see the word "orange" or "green" in there so I assume the module is working. Since it's not fixing the basicIntegrity though, I'll just remove it.

Thanks!
 

Topogigi

Senior Member
Oct 21, 2005
1,414
1,525
0
Turin
In my case, the world "yellow" was found in the file instead of the expected "orange".
So, I modified the module and in the version here attached the world "yellow" is replaced with "green"
P.S. I have a Nubia Z17, so I modified some other properties concerning root

TY for your module!
 

Attachments

hackintosh5

Senior Member
Sep 15, 2017
1,246
947
0
In my case, the world "yellow" was found in the file instead of the expected "orange".
So, I modified the module and in the version here attached the world "yellow" is replaced with "green"
P.S. I have a Nubia Z17, so I modified some other properties concerning root

TY for your module!
I'll push and update on around an hour.

Edit: updated.

Sent from my kminiltexx using XDA Labs
 
Last edited:

hackintosh5

Senior Member
Sep 15, 2017
1,246
947
0
In my case, the world "yellow" was found in the file instead of the expected "orange".
So, I modified the module and in the version here attached the world "yellow" is replaced with "green"
P.S. I have a Nubia Z17, so I modified some other properties concerning root

TY for your module!
Just a kind request to others, please don't repost this file!

It'd be great if that not was added into the quoted post too.

Sent from my kminiltexx using XDA Labs