Development [RECOVERY][3.7.0-12.1][UNOFFICIAL][UNIFIED] TWRP with A12/A13 encryption support

[Andsie]

Success - error gone...

Many thanks for the helpful work!

 

[osm0sis]

Update

• fix Magisk installation bug
• fix "failed to mount '/vendor_dlkm (Block device required)" error message on OOS

05-01-23 - Google Drive

drive.google.com

What was breaking losetup?!

I was about to try it with my busybox builds today to see if it worked any better.

Official TWRP status wen?

 

[der_akinator]

What was breaking losetup?!

I was about to try it with my busybox builds today to see if it worked any better.

Official TWRP status wen?

I disabled internal TWRP APEX handling. I think TWRP might have blocked the loop devices but I'm not sure why magisk installer couldn't create a new loop device. Maybe loop-control was constantly blocked by TWRP.

I will do a bit of code cleanup and ask in zulip to make it official.

 

[osm0sis]

I disabled internal TWRP APEX handling. I think TWRP might have blocked the loop devices but I'm not sure why magisk installer couldn't create a new loop device. Maybe loop-control was constantly blocked by TWRP.

I will do a bit of code cleanup and ask in zulip to make it official.

A bit of further digging today, just for my own curiosity:

It's both loop0 and loop1 which are blocked, any losetup action on them from busybox or toybox (TWRP's ramdisk losetup is toybox) will cause a hang. All loops higher than 1 behave normally.

`busybox losetup /dev/block/loop0` just silently hangs.
`toybox losetup /dev/block/loop0` displays "losetup: /dev/block/loop0: Value too large for defined data type" then hangs.

Interestingly AK3 was unaffected, though I'm not entirely sure why yet, since it still falls back to using losetup.

TWRP's never blocked the loop devices previously; not sure if it's something specific to lemonadep, lineage-20 or twrp-12.

I believe Lineage switched to .capex with lineage-20. Could it just be that TWRP's internal apex handling just doesn't know how to support .capex yet?


Edit: Aha! AK3 unmounts all existing /apex first, so it basically reset loop0 and loop1, so no hang with AK3. Well there's one part of the mystery solved anyway.

 

[Weliton]

where can i get the vendor boot??

 

[gsser]

where can i get the vendor boot??

Inside full rom zip payload or pullback from msm tool

 

[gsser]

Update

• fix Magisk installation bug
• fix "failed to mount '/vendor_dlkm (Block device required)" error message on OOS

05-01-23 - Google Drive

drive.google.com

The black magic kind i like hehe

 

[der_akinator]

where can i get the vendor boot??

Installation is now possible without flashing vendor_boot but I haven't updated the install instructions yet.

 

[der_akinator]

A bit of further digging today, just for my own curiosity:

It's both loop0 and loop1 which are blocked, any losetup action on them from busybox or toybox (TWRP's ramdisk losetup is toybox) will cause a hang. All loops higher than 1 behave normally.

`busybox losetup /dev/block/loop0` just silently hangs.
`toybox losetup /dev/block/loop0` displays "losetup: /dev/block/loop0: Value too large for defined data type" then hangs.

Interestingly AK3 was unaffected, though I'm not entirely sure why yet, since it still falls back to using losetup.

TWRP's never blocked the loop devices previously; not sure if it's something specific to lemonadep, lineage-20 or twrp-12.

I believe Lineage switched to .capex with lineage-20. Could it just be that TWRP's internal apex handling just doesn't know how to support .capex yet?


Edit: Aha! AK3 unmounts all existing /apex first, so it basically reset loop0 and loop1, so no hang with AK3. Well there's one part of the mystery solved anyway.

I also noticed that TWRP keeps /dev/loop-control open as RW for its whole lifetime but that doesn't seem to be a problem because magisk installation still hangs after I patched this. Only loop0 and 1 are a problem because TWRP only loads two apex files in its current configuration.
Maybe we should create a PR for magisk to include the unmount/losetup parts from AK3. This might be helpful for devices that have apex included in TWRP. For now I just keep building it without apex support.

 

[osm0sis]

I also noticed that TWRP keeps /dev/loop-control open as RW for its whole lifetime but that doesn't seem to be a problem because magisk installation still hangs after I patched this. Only loop0 and 1 are a problem because TWRP only loads two apex files in its current configuration.
Maybe we should create a PR for magisk to include the unmount/losetup parts from AK3. This might be helpful for devices that have apex included in TWRP. For now I just keep building it without apex support.

Nah, it's definitely more an issue on TWRP's side, since it didn't used to hold the loops the way it currently is which causes the hangs. My guess is still that TWRP is lacking .capex support.

Magisk not unmounting them is technically better than what I currently do in AK3 since after install everything goes back to how it was, since the installer mounts a tmpfs over /apex to not touch anything there from TWRP.

 

[javi2246]

Restore doesn't work on LOS 19.1. Force checked twice...

I made the backup without pattern/pin, now when it comes to restoring I try to do a factory reset first, I restart I enter the OS, I go back to TWRP and I do the restore, I restart and the lineageos logo stays loading, it restarts only a couple of times, I enter TWRP to get the logs (it doesn't ask for a pin) but I'm going to mount the files and it's empty, it seems that everything has been deleted, in the "mount" option there is a button that says decrypt data, but it asks for a password (text)....

 

[der_akinator]

Restore doesn't work on LOS 19.1. Force checked twice...

I made the backup without pattern/pin, now when it comes to restoring I try to do a factory reset first, I restart I enter the OS, I go back to TWRP and I do the restore, I restart and the lineageos logo stays loading, it restarts only a couple of times, I enter TWRP to get the logs (it doesn't ask for a pin) but I'm going to mount the files and it's empty, it seems that everything has been deleted, in the "mount" option there is a button that says decrypt data, but it asks for a password (text)....

I could reproduce your issue when restoring backup with pattern set. It looks like super and data shouldn't be restored at the same time.
May solution:
1. Factory reset but NOT format data in TWRP
2. Flash previously installed OTA zip.
3. Reboot to system
4. Don't set any pin/password
5. Reboot to TWRP
6. Backup should show up again and restore only data
7. Reboot to system
8. If that doesn't help reboot to TWRP and restore only super

Edit: It doesn't matter if backup is made with or without pin/pattern. It is important that pin/pattern is not present when restoring it.

 

[javi2246]

I could reproduce your issue when restoring backup with pattern set. It looks like super and data shouldn't be restored at the same time.
May solution:
1. Factory reset but NOT format data in TWRP
2. Flash previously installed OTA zip.
3. Reboot to system
4. Don't set any pin/password
5. Reboot to TWRP
6. Backup should show up again and restore only data
7. Reboot to system
8. If that doesn't help reboot to TWRP and restore only super

Edit: It doesn't matter if backup is made with or without pin/pattern. It is important that pin/pattern is not present when restoring it.

super? I'm talking from memory (I've updated to LO20 and haven't installed TWRP yet), but I didn't seem to see any partition named super, just data, efs, modem and internal storage (SD).
The rest of the steps coincide with yours, I tried several combinations without success.

 

[rav3ns]

Hello @der_akinator ,

I'm trying to install following the universal option, but I have a screen with artifacts, similar to:

In the computer I can see the device and navigate under folders, but I can't do anything obviusly.
0a4155c4cc8d0d9e99e13420241a7eb7 md5sum of boot.img , maybe is incorrect?

Also I try with the boot.img of folder 30/12 and this only returns to the fastboot mode.

Any sugestion?

 

[der_akinator]

super? I'm talking from memory (I've updated to LO20 and haven't installed TWRP yet), but I didn't seem to see any partition named super, just data, efs, modem and internal storage (SD).
The rest of the steps coincide with yours, I tried several combinations without success.

Super is the partition that contains more logical partitions like system, vendor, etc. It's basically like an OTA zip.

 

[der_akinator]

Hello @der_akinator ,

I'm trying to install following the universal option, but I have a screen with artifacts, similar to:

In the computer I can see the device and navigate under folders, but I can't do anything obviusly.
0a4155c4cc8d0d9e99e13420241a7eb7 md5sum of boot.img , maybe is incorrect?

Also I try with the boot.img of folder 30/12 and this only returns to the fastboot mode.

Any sugestion?

Do you use OP9 or pro and what OS are you running? Was your screen changed at one point? I think is has something to do with the arguments of the msm_drm kernel module which is responsible for the screen. I give it some standard arguments that work at least on the pro with custom roms.

Edit: If you have root you can send me the contents of /sys/module/msm_drm/parameters/dsi_display0 and I can include this in the next build to support other screens too.

 

[rav3ns]

Do you use OP9 or pro and what OS are you running? Was your screen changed at one point? I think is has something to do with the arguments of the msm_drm kernel module which is responsible for the screen. I give it some standard arguments that work at least on the pro with custom roms.

Edit: If you have root you can send me the contents of /sys/module/msm_drm/parameters/dsi_display0 and I can include this in the next build to support other screens too.

OP9 not Pro version.
Stock rom full updated to the last version. ( I can't remember what version was)

Finally I got a brick and I unbricked with MSM and with stock rom.


At this point I'm on Oxygen OS 11.2.10.10 LE25AA on OP9 model LE2113.
with fastboot boot twrp.img was not working.
I installed official "twrp-3.7.0_11-0-lemonadep.img" and then install with adb sideload twrp-installer-3.7.0-12.1-2-lemonadep.zip


Recovery is loaded correctly but i'm not able to use (touch isn't working) also I tryed OTB mouse & keyboard but not working.

 

[rav3ns]

Do you use OP9 or pro and what OS are you running? Was your screen changed at one point? I think is has something to do with the arguments of the msm_drm kernel module which is responsible for the screen. I give it some standard arguments that work at least on the pro with custom roms.

Edit: If you have root you can send me the contents of /sys/module/msm_drm/parameters/dsi_display0 and I can include this in the next build to support other screens too.

Attached the file /sys/module/msm_drm/parameters/dsi_display0 extracted with terminal in twrp.

Thank you a lot.

 

[der_akinator]

OP9 not Pro version.
Stock rom full updated to the last version. ( I can't remember what version was)

Finally I got a brick and I unbricked with MSM and with stock rom.


At this point I'm on Oxygen OS 11.2.10.10 LE25AA on OP9 model LE2113.
with fastboot boot twrp.img was not working.
I installed official "twrp-3.7.0_11-0-lemonadep.img" and then install with adb sideload twrp-installer-3.7.0-12.1-2-lemonadep.zip


Recovery is loaded correctly but i'm not able to use (touch isn't working) also I tryed OTB mouse & keyboard but not working.

I might have found a fix but for testing I depend on you because I haven't an OP9. If you want to stay on OOS11 you should probably use the official TWRP 3.7.0-11.0 version due to differences in encryption.

op9-test - Google Drive

drive.google.com

 

[rav3ns]

I might have found a fix but for testing I depend on you because I haven't an OP9. If you want to stay on OOS11 you should probably use the official TWRP 3.7.0-11.0 version due to differences in encryption.

op9-test - Google Drive

drive.google.com

I want to flash a rom with Android 12 / 13.
I go to test this recovery, thanks!
EDIT: installed with adb sideload and now is working! Thanks a lot!