The fix for this reboot is in https://forum.xda-developers.com/showpost.php?p=75096216&postcount=305
[ROM][7.x][T810] LineageOS 14.1 for Tab S2 9.7 wifi
- Thread starter T_I
- Start date
hmmm finally found a new rom gonna test it out now my tablet has been OOS for a while
I incorporated bonuzzz's updated repos from a couple days ago into my forks of the official repos. New features include bluetooth WBS for linking with car bluetooth systems, ANT+ antenna compatibility, as well as improved speaker and mic gains. Unfortunately, the fingerprint sensor still errors out due to my using the official kernel instead of bonuzzz's, since he's still working on his.
New builds should land in my BasketBuild in around 6 hours.
New builds should land in my BasketBuild in around 6 hours.
wbs - wide band speech. and it is not for linking to car systems etc...
at second, you inproperly copypasted ant+ support. it will not work here.
at third, stop use other's work, please. @NoCoolNamesRemain had already blamed me for all sins, but your copypasting is demotivating me to do anything. I'ca already changed mind to upload twrp, because you will copypaste my work immediately. If you want to do something useful, make something your own
Stop complaining. I already got official twrp support for all variants using my own repos, with the help of T_I's, RaymanFX's and ashyx's repos, so I wouldn't need your twrp code nor am I interested in it anyway. Not that you wouldn't contribute good code to twrp, but I have already done this. I'd casually remind you of my twrp work by posting another link to my builds, but that would make you angry again. Go to twrp.me and see for yourself. Do you understand the concept of open source development? I will re-upload my lineage repos and give you credit. Right now they're still rough drafts.
Yes, you are a superior individual since you know how to get ANT+ to work. Unless you made changes to it, it won't work in your builds either, according to your logic. If yours works it's probably because you're using your kernel, which I can't build with anyway. As I've said before, if another user can't reproduce your results with your code, then your code isn't developed enough to be reliable. Too bad you overlooked adding the sensors.exynos5.so blob line entry into the mk file of the gts210wifi blobs folder. It took me a while to figure out why my gts210wifi's screen wouldn't auto-rotate. I guess you're not so perfect.
I'd much rather you stay motivated to keep working on your kernel for the sake of the fingerprint and gts28 camera bugs.
Last edited:
Nope, only T_I and those higher ups have merge rights. But this is why I forked the official repos and I only make as few changes as possible into my forks based on bonuzzz's contributions, so as to keep them as close to the official ones as possible for the purpose of eventual merging, if the major bugs are ironed out and T_I will be willing to take a look at my forks.
The 2 lingering bugs are the camera on gts28 and the fingerprint sensor on all 4 variants. The cause must be in the kernel. Bonuzzz has shared a number of his kernel repos and we can only hope he is motivated to keep working on them, since his builds don't have these bugs, yet I'm unable to build with his kernels. Sorry, bonuzzz, but unless your builds can be reproduced by someone else, your code is unreliable.
Last edited:
what is changed? Absolutely nothing... The issues are not fixing themselves by changing status. And nobody helps...
But unofficial status has advantages for end user. You use build, which at least tested by dev instead of compiling automatically. So unofficial builds usually are more stable than official. At second, I have more liberty what I can do and how can add features, fix bugs etc. Nobody say me that my commit is not ethical or not corresponds to one's standards.
Just compare official and unofficial builds of lineageos, for example, twrp...
the problem is your commits are not more useful and often break all logic. and you spend days to copy other's work instead of fixing issues. I don't know what are you going to do when i fix netflix in my builds.
I'm beginner git user, so i will spend a lot of time to make each commit. And I started to do it for myself only without a goal to upload to public.
@NoCoolNamesRemain Hey! Here are more reasons to being frustrated by me! :laugh:
And how will you fix Netflix in your builds? There have been many attempts and only T_I's first attempt has worked so far, which is why I've kept it. You don't seem to believe me when I say that it does work. I'm a beginner myself, I just switched from GitHub Desktop to SmartGit last weekend and it's much easier to learn with a graphic UI than through the command line.
Sorry I don't understand what you mean by "only without a goal to upload to public". As I said, I took the official repos and compared them with yours to see what you did and why. You believe that your repos are more logical than the official ones. I'm not experienced enough to make that assessment, all I know is that they work and are reproducible. I'm not saying your code is bad, but if other people can't build with it, then either you're not sharing all the code you use in your builds, or all of your repos are equally different from the official ones to the extent that all your inconsistencies work only because they are consistently inconsistent, if that makes sense. The official repos have been developed by multiple people, all of whom have more experience than you or I, so I trust the official repos for this reason and also because I can build with them as they are. Your repos require modifications to work properly. I don't expect your code to be perfect, just buildable.
I don't know what I'll do if you fix Netflix. Perhaps nothing since a fix already exists and works. I don't have enough experience to be able to properly compare whatever fix you come up with in terms of its effect on any other functionality. It's very fortunate that the current one doesn't affect anything else, to the best of my knowledge.
I incorporate your code into the official repos in part to learn why you make your changes and how they differ from what more experienced devs have come up with. I don't know if your logic is better than theirs, but the first step in trusting code is being able to build with it. If you want to build your own twrp, go ahead. I won't touch it because twrp is much simpler to develop than a full rom. I taught myself how to build a working twrp device tree, and unless there's a big problem with my builds, how much more functionality would you intend on adding? I'm just asking out of curiosity.
In terms of ANT+, I'd rather you tell me what to change to make it work rather than critizing what I did. I didn't leave anything related with it out of my forks, but if what I did is different from what you did, I can appreciate how you would get the impression that my style of sticking to the official repo structure makes it look like what I did wouldn't work, because it's that much different from what you did.
You want to prove yourself in the XDA community, fine. But respect is earned through reliable results, not criticism.
@ripee I had the same thoughts about official status few years ago. Some time later you also change your mind.
If you couldn't build from my sources, feel free to ask and send logs. It's not problem at all. My phrase means that I didn't have the goal to upload my builds to public. Just to fix autobrightness to myself.
About ant+, you copypaste other's code without understanding. unfortunately. I dont know logic which you choose what copy or not copy. You have two variants: stay with official git or switch to my git. Combining two gits is useless and you also make more bugs there. And yes, I criticise you because you just copy my work. and I see how much time you spend to do it. You could spend this time to fix something else.
About official git, you have sources for t710, for example, for about an year. Anyone helps to fix something? NO. But you will be depends on hundreds commits every day and waiting when something will be broken. And you have to find what exactly has been broken, how exactly has been broken and you dont have time for anything else because your new nightly build causes bootloops.
About proof, i don't have any benefits doing this. Probably to disappoint someone, who already said his opinion about me.
But, seriously, last days and last actions are demotivating me to continue something. If you couldn't help, so just not to blame. At least, I'm one who trying to do something in last months.
---------- Post added at 10:30 PM ---------- Previous post was at 09:42 PM ----------
[/COLOR @ripee tested your build and your fix. It fixes netflix, but breaks camera.
and your build is good example. Imagine, this is an official build. I downloaded it, flashed it and got black screen after bootanimation. I dont know anything about logs, I'm just user. But I have all my work on this tablet. I'm very angry. What is your action?
ps: your build for t710 is really broken.
If you couldn't build from my sources, feel free to ask and send logs. It's not problem at all. My phrase means that I didn't have the goal to upload my builds to public. Just to fix autobrightness to myself.
About ant+, you copypaste other's code without understanding. unfortunately. I dont know logic which you choose what copy or not copy. You have two variants: stay with official git or switch to my git. Combining two gits is useless and you also make more bugs there. And yes, I criticise you because you just copy my work. and I see how much time you spend to do it. You could spend this time to fix something else.
About official git, you have sources for t710, for example, for about an year. Anyone helps to fix something? NO. But you will be depends on hundreds commits every day and waiting when something will be broken. And you have to find what exactly has been broken, how exactly has been broken and you dont have time for anything else because your new nightly build causes bootloops.
About proof, i don't have any benefits doing this. Probably to disappoint someone, who already said his opinion about me.
But, seriously, last days and last actions are demotivating me to continue something. If you couldn't help, so just not to blame. At least, I'm one who trying to do something in last months.
---------- Post added at 10:30 PM ---------- Previous post was at 09:42 PM ----------
[/COLOR @ripee tested your build and your fix. It fixes netflix, but breaks camera.
and your build is good example. Imagine, this is an official build. I downloaded it, flashed it and got black screen after bootanimation. I dont know anything about logs, I'm just user. But I have all my work on this tablet. I'm very angry. What is your action?
ps: your build for t710 is really broken.
So if you know how to fix something, please feel free to fix it. You're making an assumption that I changed my mind about official support, on what basis? I build daily because I'm too impatient to wait a week, and if the official build doesn't compile properly, then I'd have to wait another week for any updates.
The time it took me to look over your code and decide what and how to incorporate it into the official forks is the same amount of time it took me to wait patiently for you to upload your changes to your repos.
If combining your git with the official one creates more bugs, how come I'm able to build with your changes incorporated into the official code without any problems? The fault is in the kernel, not blobs or device trees.
Yes you are trying to do something, and many users have expressed their gratitude to you. But your attitude has not been very open to the community from the beginning. I wasn't the only one to ask you to share your repos, and as great as it is that you fixed auto-brightness, you made the conscious decision to involve yourself in development, no one else forced you to. Further proof of your less-than-positive attitude is your empty threat from earlier today that you don't feel motivated to work on twrp. First of all, official twrp has been out for around 1 month, so you're not depriving anyone of anything twrp-related. Secondly, no one has the power to motivate you to do anything in your life, only you. And if you didn't take on the challenge of working on lineage or twrp, someone else would have eventually.
I'll say it again: judging by your repos, your way of doing things is different enough from the official repos that it's difficult to compare them. If your way works for you, fine, but don't assume any other way is automatically more buggy or of lesser quality simply because you disagree with it. You said it yourself that you're inexperienced. Don't assume I think your way is worse than the official way, I'm interested in comparing them for the sake of my own learning about lineage development.
@ripee combine configs from board_defines and board_artifacts folders and you will receive my config.
Very very cool! You had broken build for t710. lineage-14.1-20180115-UNOFFICIAL-gts28wifi.zip -- this one. this your nightly official build. I got black screen here. Fortunately I knew how to fix it. But what about other users?
Automatic build without any testing. We got black screen. Profit!
What about sources, you simply dont know all the magic. I didn't had to edit something in configs to fix autobrightness for example. I didn't invent something very serious.
What about twrp, we have already twrp from ashyx. And he is not rush to put his work to official git. Yes, probably it has not last version, but its working. Think, why he makes twrp for years and dont even try to receive official status. Do you think everyone could help you, if you will spam everywhere? I sent you screenshots of your work. And as I know, you had testers for 71x...
Very very cool! You had broken build for t710. lineage-14.1-20180115-UNOFFICIAL-gts28wifi.zip -- this one. this your nightly official build. I got black screen here. Fortunately I knew how to fix it. But what about other users?
Automatic build without any testing. We got black screen. Profit!
What about sources, you simply dont know all the magic. I didn't had to edit something in configs to fix autobrightness for example. I didn't invent something very serious.
What about twrp, we have already twrp from ashyx. And he is not rush to put his work to official git. Yes, probably it has not last version, but its working. Think, why he makes twrp for years and dont even try to receive official status. Do you think everyone could help you, if you will spam everywhere? I sent you screenshots of your work. And as I know, you had testers for 71x...
I know you combined board_artifacts and board_defines. I asked myself why the official repo had them in separate folders not all in BoardConfigCommon and device-common. I figure it's probably easier to keep track of anything added separately into BoardConfigCommon and device-common if both of these files aren't already very long with entries from board_defines and board_artifacts. You also added a few additional sepolicy items and updated a few others. I also noticed the proper power profile for gts28 versus gts210 because the official one is just a copy of trelte. One mistake that I caught was a couple duplicate blocks of entries in the gts28 ueventd.universal5433.rc, which I shortened for you. Edit: nevermind, I guess they weren't duplicates. I'm fixing my repos now.
If you know how to fix the blank screen, how about you share that information with everyone, if you're so concerned about other people not knowing how to fix it, rather than just saying you know how to fix it?
Last edited:
it's working with clean install. At least i cant reproduce again
As a user, I much prefer that fixes be merged into the OFFICIAL version. As a general rule, any forks are likely to be deserted much sooner and will then receive no fixes whatsoever. Further, if they are incorporated into the OFFICIAL version, chances are that the changes are reviewed by more eyes.
oh yes! tab s2 has all sources of 14.1 on official git for about a year already and, I see, it's very helped to development...
@T_I: The /system/etc/permissions/android.hardware.bluetooth_le.xml file is still missing in the official build lineage-14.1-20180206-nightly-gts210wifi-signed.zip. Shouldn't the file be there already?