I full-wiped my phone and did a clean install, in order to try again the Footej camera app.Again, thanks for the feedback. Interesting that video recording isn't working for you though. I just tried using footej camera and it worked OK. I'm not sure why it wouldn't for you, but there def are still issues with the camera/video that I've spent a little time trying to look into without much luck as of yet.
Sent from my SM-G800F using Tapatalk
Is not there for me, but may be related to the fact that I've deleted flipflap.akp. Wanted to restore it, but that does not work. I'll test it at the next build, because flipflap is back.hey,
i found this on 'connected devices --> connection settings --> smart-cover'
(Verbundene Geräte --> Verbindungseinstellungen --> Smart-Cover)
the same by me. no notification led for unread messages (SMS/Threema) also with app-specific led-settings...I'm wondering about the messaging app (SMS): On my old Phone (CM12) the contacts used to have different colors, on this Rom every contact/thread is green? Does that have to do with the introduction of dark mode into the Messaging App?
Another thing is that I don't seem to get notifications for unread SMS via the Notification LED. Already tried to add App-Specific settings in the Notification light settings (only available here via Settings Search), but to no avail. Anyone else experiencing this?
Thanks, sorry if drifting OT
Just flash the new Version with the newest Version of TWRP.I am also experiencing crashs with the camera and incredible bad quality with my micro when skyping.
Thats why I want to update to the newest version (I have the version before).
Is there a way I can update without loosing again any apps and data?
Perhaps a conflict between two settings:the same by me. no notification led for unread messages (SMS/Threema) also with app-specific led-settings...
...
--- a/media/libaudioclient/include/media/AudioParameter.h
+++ b/media/libaudioclient/include/media/AudioParameter.h
@@ -76,6 +76,7 @@ public:
static const char * const valueListSeparator;
String8 toString() const { return toStringImpl(true); }
+ String8 toString();
String8 keysToString() const { return toStringImpl(false); }
status_t add(const String8& key, const String8& value);
@@ -86,8 +87,11 @@ public:
status_t remove(const String8& key);
status_t get(const String8& key, String8& value) const;
+ status_t get(const String8& key, String8& value);
status_t getInt(const String8& key, int& value) const;
+ status_t getInt(const String8& key, int& value);
status_t getFloat(const String8& key, float& value) const;
+ status_t getFloat(const String8& key, float& value);
status_t getAt(size_t index, String8& key) const;
status_t getAt(size_t index, String8& key, String8& value) const;
...
...
--- a/media/libaudioclient/include/media/AudioParameter.h
+++ b/media/libaudioclient/include/media/AudioParameter.h
@@ -87,6 +87,7 @@ public:
static const char * const keyReconfigA2dpSupported;
String8 toString() const { return toStringImpl(true); }
+ String8 toString();
String8 keysToString() const { return toStringImpl(false); }
status_t add(const String8& key, const String8& value);
@@ -97,8 +98,11 @@ public:
status_t remove(const String8& key);
status_t get(const String8& key, String8& value) const;
+ status_t get(const String8& key, String8& value);
status_t getInt(const String8& key, int& value) const;
+ status_t getInt(const String8& key, int& value);
status_t getFloat(const String8& key, float& value) const;
+ status_t getFloat(const String8& key, float& value);
status_t getAt(size_t index, String8& key) const;
status_t getAt(size_t index, String8& key, String8& value) const;
...
First apologies for being absent from this thread for awhile. Real life has just kept me really busy lately.Hi @spookcity138
Do you have time for a quick "building from Source question"?
I'm hitting a few problems and I'm trying to understand "why", when building from branch "P". Currently my build (mka bacon) fails (fatal error), but before getting bogged down in that, I noticed that I have issues applying the patches (./apply.sh). Having taken a deeper look I'm now confused how you publish builds for Branch "P" without hitting the same issue.
For example, the first issue I hit is with ..../frameworks_av/0003-audio-add-non-const-AudioParameter-methods-for-backw.patch. The patch from your local repo reads:
Code:... --- a/media/libaudioclient/include/media/AudioParameter.h +++ b/media/libaudioclient/include/media/AudioParameter.h @@ -76,6 +76,7 @@ public: static const char * const valueListSeparator; String8 toString() const { return toStringImpl(true); } + String8 toString(); String8 keysToString() const { return toStringImpl(false); } status_t add(const String8& key, const String8& value); @@ -86,8 +87,11 @@ public: status_t remove(const String8& key); status_t get(const String8& key, String8& value) const; + status_t get(const String8& key, String8& value); status_t getInt(const String8& key, int& value) const; + status_t getInt(const String8& key, int& value); status_t getFloat(const String8& key, float& value) const; + status_t getFloat(const String8& key, float& value); status_t getAt(size_t index, String8& key) const; status_t getAt(size_t index, String8& key, String8& value) const; ...
However to get the patch to apply, I have to change it to what's shown below (notice the line numbers are changes):
Code:... --- a/media/libaudioclient/include/media/AudioParameter.h +++ b/media/libaudioclient/include/media/AudioParameter.h @@ -87,6 +87,7 @@ public: static const char * const keyReconfigA2dpSupported; String8 toString() const { return toStringImpl(true); } + String8 toString(); String8 keysToString() const { return toStringImpl(false); } status_t add(const String8& key, const String8& value); @@ -97,8 +98,11 @@ public: status_t remove(const String8& key); status_t get(const String8& key, String8& value) const; + status_t get(const String8& key, String8& value); status_t getInt(const String8& key, int& value) const; + status_t getInt(const String8& key, int& value); status_t getFloat(const String8& key, float& value) const; + status_t getFloat(const String8& key, float& value); status_t getAt(size_t index, String8& key) const; status_t getAt(size_t index, String8& key, String8& value) const; ...
Can I ask, "How do you build from branch 'P' without hitting the issue(s) I'm seeing". It makes me uncomfortable when I deviate from your repo's source without understanding why. FYI, I have issues with other patch files too, *but* I'm hoping your insight will help answer the wider question.
Many thanks!
EDIT: I've attached the three patch files that needed to be slightly modified (to work in my environment) and for me the build now completes without error. I'll also submitted a pull request on GitHub which may be (?) a better / easier place to view/discuss.
I recently built on 25.6. with the unmodified original patches above without errors.First apologies for being absent from this thread for awhile. Real life has just kept me really busy lately.
It's strange because I recall @Panzerknakker having issues with a patch in system/core. I looked into this and it applied without issue for me,so I didn't look into it anymore. I know that @rodman01 has built resurrection remix recently. Maybe he can chime in on whether he also had issues with the patches.
Hi @spookcity138...or you can do as i do and create a simple debloat script to remove this along with anything else you may not want/use. I personally remove a few things this way (FlipFlap,AudioFx etc)
...
The issues you're having with the patches are interesting. I had no issues when I last built 2 weeks ago-ish. I don't really see why I wouldn't yet you are as the sources are the same.
...
Thanks for confirming. I guess I'm the outlier!I recently built on 25.6. with the unmodified original patches above without errors.
...
I have pushed a P_custom branch to github. It has a lot features and optimizations from my N_custom branch that were relatively easy to bring over. Perhaps you can just try to use this branch in the future for your builds...Assuming it is stable for you. It has been for me in a few days of testing. Although I have used a custom toolchain to build mine and cant say for sure if it will build successfully with the stock google toolchain.. You can see exactly what I've done HereI recently built on 25.6. with the unmodified original patches above without errors.
The patchset 12-OC-Kernel-Patches-Lineage-16.0-kminilte.tar.gz
https://www.androidfilehost.com/?fid=6006931924117904388
adds OC from Spookcity's N-kernel.
It has to be unpacked into device/samsung/smdk3470-common/patch/kernel_samsung_kminilte directory.
Of course. It is a bit sloppy in the sense that I have used it for other ROMS in the past (AEX,etc) so there are apps and app locations (priv-app vs app) that don't apply to this ROM,but this has no effect on the script succeeding. Please anyone who may decide to use this: DO NOT FLASH BLINDLY!! Open up the update-script and examine it! I remove a lot of stuff. Some which I am positive others want. Make sure you delete any lines with apps you wish to keep. You have been warned!
And I’m guessing that has to be done in TWRP?The patchset 12-OC-Kernel-Patches-Lineage-16.0-kminilte.tar.gz
https://www.androidfilehost.com/?fid=6006931924117904388
adds OC from Spookcity's N-kernel.
It has to be unpacked into device/samsung/smdk3470-common/patch/kernel_samsung_kminilte directory.
Sorry, no, just for building the Rom / compiling the kernel.And I’m guessing that has to be done in TWRP?