[ROM][EXYNOS] LineageOS 17.1 for S10e|S10|S10+ - v1.4 (UPDATE: 2020-12-17)

[exxxtreme]

SD card encryption

First of all, thank you for your work on this, and especially for the great instructions for installing the ROM (I've been struggling with installation of other ROMs on the S10e, with instructions spread over a number of threads ).
I just finished installing your ROM, and after doing a bit of discovery, I realized I don't know how to encrypt the sd card. Is this supported? I am happy to either use the SD card as internal storage, or portable, either way would be fine if I can get it to be encrypted.

Thank you in advance

 

[modpunk]

First of all, thank you for your work on this, and especially for the great instructions for installing the ROM (I've been struggling with installation of other ROMs on the S10e, with instructions spread over a number of threads ).
I just finished installing your ROM, and after doing a bit of discovery, I realized I don't know how to encrypt the sd card. Is this supported? I am happy to either use the SD card as internal storage, or portable, either way would be fine if I can get it to be encrypted.

Thank you in advance

Using it as internal storage should encrypt it, but I'm not 100% sure. I've never tried it.

 

[modpunk]

RC1 is out

New Kernel and performance improvements through new power HAL!

 

[ctrej]

This is how open source should work. Thank you very much for your contribution. This is much appreciated. I did some minor fixes and changed the FAQ!

THANK YOU VERY MUCH!

You're welcome, and indeed this is how open source should work

I'll probably add some more details once I've set up my phone completely (I still need magisk) and later after the update, if I think it would be helpful. You'll still have the option to only merge the parts you like.

I was able to figure this out myself.
That was an easy fix.

It should be added to the first post, for others which are used to the "old" behaviour of updating roms, etc.

Thanks anyway.

Will add that to the FAQ by the end of the week, thanks for the info

I'm already at G970FXXU7CTF1, should I just wait for RC1?

Its out now

Does the installed official device firmware have any influence on how the rom works?
Or is it just a neccessary step to install lineageos?

It's hard to deliver (nearly) bug-free software for anything, but it becomes ridiculous if you have to test multiple versions. There might be some low-level hardware drivers that are not included in the ROM and thus some hardware might not work. (Based on experience of the redmi4x, if you didn't update the firmware before flashing, the sensors wouldn't work).

First of all, thank you for your work on this, and especially for the great instructions for installing the ROM (I've been struggling with installation of other ROMs on the S10e, with instructions spread over a number of threads ).
I just finished installing your ROM, and after doing a bit of discovery, I realized I don't know how to encrypt the sd card. Is this supported? I am happy to either use the SD card as internal storage, or portable, either way would be fine if I can get it to be encrypted.

Thank you in advance

I planned to use veracrypt to create an encrypted container on my microSD and use EDS lite to access it. With this setup you could access data on a PC as well, if you have the password.

 

[ned14]

Open Camera is great and supports a lot of the camera's features with the camera API v2 (select this option in the settings):
All cameras supported (normal, wide angle, telephoto, front, front-cropped)
Manual change of exposure, aperture, shutter speed, ISO
Multiple focus options that work with the PDAF (Phase-Difference Auto Focus, is much faster and more precise then "regular" contrast based AF)
The (main) developer uses an S10e himself so you can expect good HW support

My S10 arrived today, so after much unlocking rigmarole, just flashed RC1 onto it. Installed OpenCamera v1.48.1 from F-Droid. Set the Camera2 API. Four cameras are detected according to the version page, two for back (wide and normal), two for front (zoomed in and normal). I'm not seeing the telephoto lens at all.

Am I missing something? I thought maybe if I adjust the zoom for the normal, maybe it switches camera used? I tried sticking my finger over each back camera. Definitely the middle one is always being used for normal, no matter the zoom chosen. I'm probably being stupid, do I need to change a setting in OpenCamera or something?

Edit: Just to be clear, if in OpenCamera you open the drop down settings and choose Aperture F/2.4, it does NOT change the camera used. You can test this using your finger. Some online sources say this can happen due to insufficient light, I tried this outdoors in a sunny day with direct sunshine.

 

[okloloi]

First of all, thanks for all the work on this rom! Been running since beta 2 with no real issues.

Just some info that might help others when updating to CTF1 firmware, I had to add the vbmeta_disabler.img into the tar with the dt.img to boot.
I was using odin so no idea if heimdall has any issues with updating.

 

[nten2]

Hello! how to run gpay on this firmware

 

[ctrej]

My S10 arrived today, so after much unlocking rigmarole, just flashed RC1 onto it. Installed OpenCamera v1.48.1 from F-Droid. Set the Camera2 API. Four cameras are detected according to the version page, two for back (wide and normal), two for front (zoomed in and normal). I'm not seeing the telephoto lens at all.

Am I missing something? I thought maybe if I adjust the zoom for the normal, maybe it switches camera used? I tried sticking my finger over each back camera. Definitely the middle one is always being used for normal, no matter the zoom chosen. I'm probably being stupid, do I need to change a setting in OpenCamera or something?

Edit: Just to be clear, if in OpenCamera you open the drop down settings and choose Aperture F/2.4, it does NOT change the camera used. You can test this using your finger. Some online sources say this can happen due to insufficient light, I tried this outdoors in a sunny day with direct sunshine.

Welp, I do only have the S10e and because all 4 cameras worked and I knew open camera supports all 5 on stock, I thought all 5 should work. Sorry for the confusion, totally my fault. So thank you for reporting this issue. One question: If you go to opencamera/settings/about, does it report 4 or 5 cameras to you? @modpunk can you please change the FAQ and take a look at the issue?

Both aperatures (1.5 and 2.4) are done with the main camera. At 2.4 you will hear a small click and see that the physical aperature is smaller. Unlike the telephoto I've tested this on my S10e and it works as intended (on beta3).

Just some info that might help others when updating to CTF1 firmware, I had to add the vbmeta_disabler.img into the tar with the dt.img to boot.
I was using odin so no idea if heimdall has any issues with updating.

Thank you for this feedback, I'll add this to the next revision of the FAQ.

Hello! How to run gpay on this firmware?

I'm not sure if it's possible. If you try methods intended for other ROM (at your own risk) and find one that's working please report back.

 

[ned14]

Welp, I do only have the S10e and because all 4 cameras worked and I knew open camera supports all 5 on stock, I thought all 5 should work. Sorry for the confusion, totally my fault. So thank you for reporting this issue.

No need to apologise. It's very hard to accomodate hardware that you don't have access to.

I trawled through the OpenCamera issue tracker, and from there it seems that OpenCamera uses whatever the OS tells it. So I suspect that the cause is that for the S10 build, a single line in some props file somewhere has the S10e setting, not the S10 setting.

One question: If you go to opencamera/settings/about, does it report 4 or 5 cameras to you? @modpunk can you please change the FAQ and take a look at the issue?

In the About screen which is a big long wall of text, it says "No. of cameras: 4"

If you cycle through the back cameras, camera id 0 is the normal (middle) lens; camera id 2 is the wide (closest to volume button) lens. That suggests to me that camera id 1 ought to be the telephoto lens. I don't know if that helps figure out what .prop file to fix.

Both aperatures (1.5 and 2.4) are done with the main camera. At 2.4 you will hear a small click and see that the physical aperature is smaller. Unlike the telephoto I've tested this on my S10e and it works as intended (on beta3).

Aha! Yes, if I look at the back of the phone and toggle the setting, the camera's apeture visibly changes size. The reason I didn't see this before is because of that sunny day, I assumed surely a darker image would result. Thanks for the tip.

 

[fishnetfancy]

Installation:
We don't have a fix for this yet! (Please try to disable pin/pattern in the android settings before entering TWRP and report back if that helps).

Thank you for your amazing work on this ROM. I have just updated from Beta 3 to RC1 and can confirm that removing pin/password/pattern prior to flashing works and does not trigger the one day delay

FYI: When removing the lock feature all store fingerprints are erased as well.

 

[ctrej]

In the About screen which is a big long wall of text, it says "No. of cameras: 4"

If you cycle through the back cameras, camera id 0 is the normal (middle) lens; camera id 2 is the wide (closest to volume button) lens. That suggests to me that camera id 1 ought to be the telephoto lens. I don't know if that helps figure out what .prop file to fix.

The IDs 1 and 3 are associated with the front camera and it's crop mode - so I'd guess the telephoto should be ID 5. Because only 4 cameras are detected, it is likely that the issue lies somewhere within this ROM - the question was just ensure that it's not an opencamera bug.

Aha! Yes, if I look at the back of the phone and toggle the setting, the camera's aperture visibly changes size. The reason I didn't see this before is because of that sunny day, I assumed surely a darker image would result. Thanks for the tip.

The camera hardware changes ISO and shutter speed to get a correct exposure. A larger aperture (f1.5) will let in more light (which is great in dark environment), while the smaller aperture (f2.4) will let in less light, but give a larger depth of field (ie. more stuff is in focus). F2.4 will also only use the center part of the lens where production tolerances are better and thus the image should be slightly sharper, especially in the corners. For general purpose f2.4 is better imho, but unfortunately opencamera selects f1.5 as default after starting and does not automatically switch based on light conditions...

The difference is not huge though, only about 1 f-stop, meaning that the smaller aperture will let in half as much light. The rule is: double f-number (eg. f4.0 -> f8.0) lets in a quarter of the light. If needed, one can look up tables eg .on wikipedia.

It's worth noting that the background-out-of-focus depends not only on the f-number, but also the chip size. This is the reason why phones have to cheat in software to get portrait-like shot with out-of-focus backgrounds. If you're curios you can try out the difference between the cameras and the f-numbers in this online DOF simulator. I've added the 4 different settings (ultrawide, wide f1.5, wide f2.4, tele) and a bunch of possible settings based on a low end Canon DLSR as a comparison.

 

[fishnetfancy]

In the About screen which is a big long wall of text, it says "No. of cameras: 4"

If you cycle through the back cameras, camera id 0 is the normal (middle) lens; camera id 2 is the wide (closest to volume button) lens. That suggests to me that camera id 1 ought to be the telephoto lens. I don't know if that helps figure out what .prop file to fix.

Same with S10+ using OpenCamera with API2. S10 Plus supposedly has three rear and two front-facing cameras.

 

[ctrej]

Thank you for your amazing work on this ROM. I have just updated from Beta 3 to RC1 and can confirm that removing pin/password/pattern prior to flashing works and does not trigger the one day delay

That's great news, thanks! I can't edit modpunks post, so we'll have to wait for him to update it.

FYI: When removing the lock feature all store fingerprints are erased as well.

Yeah, it's a side effect because afaik the pin/password/pattern is used as a master key and the fingerprint just as a weaker alternative key. It's still faster to set up the fingerprints then to wait that day. Which resets btw when you turn off the phone. Guess how I found that out. :silly:

---------- Post added at 09:10 PM ---------- Previous post was at 09:03 PM ----------

Same with S10+ using OpenCamera with API2. S10 Plus supposedly has three rear and two front-facing cameras.

The second front camera is an 8MP depth sensor and can't produce an image on it's own. Samsung merges the extra data in their camera app to get the out-of-focus background. I doubt that lineage/opencamera has a feature like this in the near future. (detaild device comparison, including cameras)

Like the S10e and S10 the front camera is a "wide" 26mm lens. In software it gets cropped to offer a "second" camera option with a narrower field of view, but all it does it throw the extra pixels away.

 

[modpunk]

The IDs 1 and 3 are associated with the front camera and it's crop mode - so I'd guess the telephoto should be ID 5. Because only 4 cameras are detected, it is likely that the issue lies somewhere within this ROM - the question was just ensure that it's not an opencamera bug.

There is an AOSP camera API for getting the ID and a Samsung one. If I add a shim to use the samsung one we get more IDs but they report errors when switching to them. Help is welcome to reverse engineer this, just contact me

Code:
https://github.com/cryptomilk/andro...mmit/23be7ab0ab5ab9aa758e7f25cc49a11265663634

 

[ned14]

The IDs 1 and 3 are associated with the front camera and it's crop mode - so I'd guess the telephoto should be ID 5. Because only 4 cameras are detected, it is likely that the issue lies somewhere within this ROM - the question was just ensure that it's not an opencamera bug.

Testing it there now:

• Id 0: Back normal lens (centre)
• Id 1: Front lens cropped
• Id 2: Back wide lens (closest to volume buttons)
• Id 3: Front lens full

So I'd suggest it would be Id 4, not Id 5, which ought to be the telephoto lens.

The camera hardware changes ISO and shutter speed to get a correct exposure. A larger aperture (f1.5) will let in more light (which is great in dark environment), while the smaller aperture (f2.4) will let in less light, but give a larger depth of field (ie. more stuff is in focus). F2.4 will also only use the center part of the lens where production tolerances are better and thus the image should be slightly sharper, especially in the corners. For general purpose f2.4 is better imho, but unfortunately opencamera selects f1.5 as default after starting and does not automatically switch based on light conditions...

... though, in the end, now I know I must do it manually, that's okay with me.

It's worth noting that the background-out-of-focus depends not only on the f-number, but also the chip size. This is the reason why phones have to cheat in software to get portrait-like shot with out-of-focus backgrounds. If you're curios you can try out the difference between the cameras and the f-numbers in this online DOF simulator. I've added the 4 different settings (ultrawide, wide f1.5, wide f2.4, tele) and a bunch of possible settings based on a low end Canon DLSR as a comparison.

You're getting me interested in photography once again! Back before children, when I had the time, I had a lot of fun with that stuff. Since, well if I'm not sleeping or working, I'm on childcare.

Thanks for all the info, it's useful. To be honest, this new phone is because my current HTC 10's battery is nearing end of life. I chose the S10 purely based on not being wider than the HTC 10, lineageos availability and cost (less than 500 euro, new, just recently) rather than any other factors. These cameras look like they'll be a large step upwards from the HTC 10's, which was pretty good in its day for a smartphone. I'm feeling excited.

 

[angela5246]

@modpunk, thanks for the new release. It seems the update brings two regressions (tested on S10e):

1) DT2W doesnt work after reboot
2) Rebooting into recovery doesnt work. Phone goes straight back to Android instead of TWRP
3) Reboot or shutdown takes an exceptionally long time. Like 30 seconds.

 

[florek_18]

Probably somebody answered already but I have a problem. I have proper twrp of course, checked verify zip. During installation I have no problems but when I reboot system it keeps rebooting back to twrp.
Anyone ? Please help

 

[fishnetfancy]

procedure to get Magisk back after ROM update

Apologies if this has been explained before but I couldn't find the answer.

Upon upgrading to RC1 and rebooting I realised that Magisk was not installed anymore. I tried to boot into recovery but the phone will now always boot into the system. I also can't turn off the phone - again it will just reboot into the system. When I launch Magisk manager I can download the Zip but the installation fails.

I did follow the upgrade guide on the first page but am now stuck and don't know how to proceed - any pointers in the right direction are much appreciated!

 

[chiragcqc]

Hi i installed your version of lineage but im facing an issue when i turn the device off and try to charge the device it keeps restarting can someone please help me i cant even power off the device and it when i left it for 10 minutes it just froze do you think installing magisk could be the reason for this issue

 

[chiragcqc]

Installed. Tested. Works great. @modpunk, you forgot to mention that phone off charging is fixed now too.

hi can you please tell me how to fix phone off charging issue i am using the latest version thanks