[ROM] LineageOS 20.0 UNOFFICIAL - 1.2 [2023-05-10]

[Rrreutel]

so does that differ in any way from how I implemented it for yoshino in 1.2 ( https://github.com/whatawurst/android_device_sony_yoshino-common/pull/97/commits/9d2880207619776820ddc85dc9cf6b56d1a723a4 )? from my limited tests it also stops charging properly.

Ah, I hadn't seen that you had your own PR ready. To be clear: you mention you've implemented it for 1.2, do you mean it's already included in your recently uploaded 1.2 version?

My version is very similar (adapted from here). Only difference is that you have a separate config/init/ueventd.yoshino.rc file, I added the entry from there directly to the existing ueventd.rc .

Yesterday I noticed a a smaller bug in the hal topic (the start time and the target time were interpreted as UTC time, causing the actual times to be 2 hours off in my UTC+2 region), it's fixed now, just tested it.

Still I'm not sure if the feature works completely as intended on our device, e.g. I think there's a separate red battery statusbar indicator icon which is supposed to be shown when charging is suspended. In our case the icon just stays white with charging bolt (even though it has actually paused charging). That icon did appear when I configured to use
/sys/class/power_supply/battery/charging_enabled
instead of
/sys/class/power_supply/battery/smart_charging_interruption

But using that node charging started jittering when the limit was reached (charging control turning charging off, and charging service turning it back on because a charger is connected).

Anyway, the statusbar icon is hopefully just cosmetic, most important is we can now stretch the life of our older batteries a bit further!

edit: smart_charging_activation->smart_charging_interruption

 

[Rrreutel]

To remove confusion about the Charging Control feature: it's mentioned in the changelog for XZ1, so it's indeed already included in @derf elot s latest 1.2 release for lilac as well. Great!

One bug that's probably still in there I mentioned above: the start time and target time you enter are interpreted as UTC time, so if you're in UTC+3 and you like to set a target time of 07:00am, you probably have to enter 04:00am in the settings. The charging control notification will then display 07:00am.

 

[petefoth]

I have successfully made /e/OS and LIneage4Microg builds with the latest code, but I am getting an error when making an IodéOS build It comes at the end of the build when the final zip file is being constructed. The full log is attached, but the interesting bit seems to be

2023-05-27 00:48:11 - common.py - INFO    :   Running: "/home/pete/srv/iodeOS4/out/host/linux-x86/bin/checkvintf --check-compat --dirmap /odm:out/target/product/lilac/obj/PACKAGING/target_files_intermediates/lineage_lilac-target_files-eng.pete/VENDOR/odm --dirmap /product:out/target/product/lilac/obj/PACKAGING/target_files_intermediates/lineage_lilac-target_files-eng.pete/SYSTEM/product --dirmap /system:out/target/product/lilac/obj/PACKAGING/target_files_intermediates/lineage_lilac-target_files-eng.pete/SYSTEM --dirmap /system_ext:out/target/product/lilac/obj/PACKAGING/target_files_intermediates/lineage_lilac-target_files-eng.pete/SYSTEM/system_ext --dirmap /vendor:out/target/product/lilac/obj/PACKAGING/target_files_intermediates/lineage_lilac-target_files-eng.pete/VENDOR --property ro.product.first_api_level=26 --property ro.boot.product.hardware.sku= --property ro.boot.product.vendor.sku="
Traceback (most recent call last):
  File "/home/pete/srv/iodeOS4/out/host/linux-x86/bin/ota_from_target_files/internal/stdlib/runpy.py", line 196, in _run_module_as_main
  File "/home/pete/srv/iodeOS4/out/host/linux-x86/bin/ota_from_target_files/internal/stdlib/runpy.py", line 86, in _run_code
  File "/home/pete/srv/iodeOS4/out/host/linux-x86/bin/ota_from_target_files/__main__.py", line 12, in <module>
  File "/home/pete/srv/iodeOS4/out/host/linux-x86/bin/ota_from_target_files/internal/stdlib/runpy.py", line 196, in _run_module_as_main
  File "/home/pete/srv/iodeOS4/out/host/linux-x86/bin/ota_from_target_files/internal/stdlib/runpy.py", line 86, in _run_code
  File "/home/pete/srv/iodeOS4/out/host/linux-x86/bin/ota_from_target_files/ota_from_target_files.py", line 1656, in <module>
  File "/home/pete/srv/iodeOS4/out/host/linux-x86/bin/ota_from_target_files/ota_from_target_files.py", line 1633, in main
  File "/home/pete/srv/iodeOS4/out/host/linux-x86/bin/ota_from_target_files/non_ab_ota.py", line 619, in GenerateNonAbOtaPackage
  File "/home/pete/srv/iodeOS4/out/host/linux-x86/bin/ota_from_target_files/non_ab_ota.py", line 263, in WriteFullOTAPackage
  File "/home/pete/srv/iodeOS4/out/host/linux-x86/bin/ota_from_target_files/check_target_files_vintf.py", line 252, in CheckVintfIfTrebleEnabled
  File "/home/pete/srv/iodeOS4/out/host/linux-x86/bin/ota_from_target_files/check_target_files_vintf.py", line 220, in CheckVintf
  File "/home/pete/srv/iodeOS4/out/host/linux-x86/bin/ota_from_target_files/check_target_files_vintf.py", line 151, in CheckVintfFromExtractedTargetFiles
common.ExternalError: Failed to run command 'checkvintf --check-compat --dirmap /odm:out/target/product/lilac/obj/PACKAGING/target_files_intermediates/lineage_lilac-target_files-eng.pete/VENDOR/odm --dirmap /product:out/target/product/lilac/obj/PACKAGING/target_files_intermediates/lineage_lilac-target_files-eng.pete/SYSTEM/product --dirmap /system:out/target/product/lilac/obj/PACKAGING/target_files_intermediates/lineage_lilac-target_files-eng.pete/SYSTEM --dirmap /system_ext:out/target/product/lilac/obj/PACKAGING/target_files_intermediates/lineage_lilac-target_files-eng.pete/SYSTEM/system_ext --dirmap /vendor:out/target/product/lilac/obj/PACKAGING/target_files_intermediates/lineage_lilac-target_files-eng.pete/VENDOR --property ro.product.first_api_level=26 --property ro.boot.product.hardware.sku= --property ro.boot.product.vendor.sku=' (exit code 70):

Any clues how to fix this or where to start looking?

Thanks

 

[Dfis]

Hello.
The microphone is a very low volume on normal calls but ok on Speaker mode...
Does anyone else experience a similar issue?

 

[Maflo]

Hello.
The microphone is a very low volume on normal calls but ok on Speaker mode...
Does anyone else experience a similar issue?

Same...

 

[Dfis]

Same...

I tried to install stock image but still the same behavior... Maybe the root caused a damage to the microphone's config...
Does anyone know how to solve this?... Maybe Magisk module?

 

[ninjy]

Hi,
I flashed twrp-3.6.2_12-0-20221002-lilac, but it seems to getting stuck on the logo.
Or it is normal it may take forever to load the UI ?

twrp-3.3.1-0-lilac-android10-1 from TWRP recovery is working fine

 

[4qx]

Does Magisk work okay for everyone? I updated to lineage 20 v1.2, reinstalled Magisk v 26.1, and it simply has no effect on apps

 

[Danko Jones]

I have successfully made /e/OS and LIneage4Microg builds with the latest code, but I am getting an error when making an IodéOS build It comes at the end of the build when the final zip file is being constructed. The full log is attached, but the interesting bit seems to be

2023-05-27 00:48:11 - common.py - INFO    :   Running: "/home/pete/srv/iodeOS4/out/host/linux-x86/bin/checkvintf --check-compat --dirmap /odm:out/target/product/lilac/obj/PACKAGING/target_files_intermediates/lineage_lilac-target_files-eng.pete/VENDOR/odm --dirmap /product:out/target/product/lilac/obj/PACKAGING/target_files_intermediates/lineage_lilac-target_files-eng.pete/SYSTEM/product --dirmap /system:out/target/product/lilac/obj/PACKAGING/target_files_intermediates/lineage_lilac-target_files-eng.pete/SYSTEM --dirmap /system_ext:out/target/product/lilac/obj/PACKAGING/target_files_intermediates/lineage_lilac-target_files-eng.pete/SYSTEM/system_ext --dirmap /vendor:out/target/product/lilac/obj/PACKAGING/target_files_intermediates/lineage_lilac-target_files-eng.pete/VENDOR --property ro.product.first_api_level=26 --property ro.boot.product.hardware.sku= --property ro.boot.product.vendor.sku="
Traceback (most recent call last):
  File "/home/pete/srv/iodeOS4/out/host/linux-x86/bin/ota_from_target_files/internal/stdlib/runpy.py", line 196, in _run_module_as_main
  File "/home/pete/srv/iodeOS4/out/host/linux-x86/bin/ota_from_target_files/internal/stdlib/runpy.py", line 86, in _run_code
  File "/home/pete/srv/iodeOS4/out/host/linux-x86/bin/ota_from_target_files/__main__.py", line 12, in <module>
  File "/home/pete/srv/iodeOS4/out/host/linux-x86/bin/ota_from_target_files/internal/stdlib/runpy.py", line 196, in _run_module_as_main
  File "/home/pete/srv/iodeOS4/out/host/linux-x86/bin/ota_from_target_files/internal/stdlib/runpy.py", line 86, in _run_code
  File "/home/pete/srv/iodeOS4/out/host/linux-x86/bin/ota_from_target_files/ota_from_target_files.py", line 1656, in <module>
  File "/home/pete/srv/iodeOS4/out/host/linux-x86/bin/ota_from_target_files/ota_from_target_files.py", line 1633, in main
  File "/home/pete/srv/iodeOS4/out/host/linux-x86/bin/ota_from_target_files/non_ab_ota.py", line 619, in GenerateNonAbOtaPackage
  File "/home/pete/srv/iodeOS4/out/host/linux-x86/bin/ota_from_target_files/non_ab_ota.py", line 263, in WriteFullOTAPackage
  File "/home/pete/srv/iodeOS4/out/host/linux-x86/bin/ota_from_target_files/check_target_files_vintf.py", line 252, in CheckVintfIfTrebleEnabled
  File "/home/pete/srv/iodeOS4/out/host/linux-x86/bin/ota_from_target_files/check_target_files_vintf.py", line 220, in CheckVintf
  File "/home/pete/srv/iodeOS4/out/host/linux-x86/bin/ota_from_target_files/check_target_files_vintf.py", line 151, in CheckVintfFromExtractedTargetFiles
common.ExternalError: Failed to run command 'checkvintf --check-compat --dirmap /odm:out/target/product/lilac/obj/PACKAGING/target_files_intermediates/lineage_lilac-target_files-eng.pete/VENDOR/odm --dirmap /product:out/target/product/lilac/obj/PACKAGING/target_files_intermediates/lineage_lilac-target_files-eng.pete/SYSTEM/product --dirmap /system:out/target/product/lilac/obj/PACKAGING/target_files_intermediates/lineage_lilac-target_files-eng.pete/SYSTEM --dirmap /system_ext:out/target/product/lilac/obj/PACKAGING/target_files_intermediates/lineage_lilac-target_files-eng.pete/SYSTEM/system_ext --dirmap /vendor:out/target/product/lilac/obj/PACKAGING/target_files_intermediates/lineage_lilac-target_files-eng.pete/VENDOR --property ro.product.first_api_level=26 --property ro.boot.product.hardware.sku= --property ro.boot.product.vendor.sku=' (exit code 70):

Any clues how to fix this or where to start looking?

Thanks

Really looking forward to the next LIneage4Microg update with battery care options. Many thanks in advance @petefoth !

 

[petefoth]

Really looking forward to the next LIneage4Microg update with battery care options.

Well the ROM is uploaded to AndroidFileHost

lineage-20.0-20230529-4microg-UNOFFICIAL-lilac.zip

It includes the 'LineageOS "Charging control hal" for battery charging care' code, but I can't see any UI for smart charging or battery care. Maybe it is waiting on upstream changes in LineageOS. Anyway, the build runs, does include the MicroG code, and location seems to work, so enjoy!

 

[petefoth]

am getting an error when making an IodéOS build It comes at the end of the build when the final zip file is being constructed. The full log is attached, but the interesting bit seems to be

<snip>

Any clues how to fix this or where to start looking?

I really want to get IodéOS working with the lates code, but it wont be happening unless someone can give me a clue how to go about fixing this build error. Pretty please...

 

[Rrreutel]

It includes the 'LineageOS "Charging control hal" for battery charging care' code, but I can't see any UI for smart charging or battery care. Maybe it is waiting on upstream changes in LineageOS. Anyway, the build runs, does include the MicroG code, and location seems to work, so enjoy!

In order to get complete functionality you need to do 2 things before building:

1) pick the LOS HAL topic:
$ cd <LOS repo root dir>
$ repopick -t charging-control-hal-20

2) pick this PR from the whatawurst Yoshino-common device repo:

yoshino-common: Build lineage health HAL and related sepolicies by derfelot · Pull Request #97 · whatawurst/android_device_sony_yoshino-common

Change-Id: I1ca5f25f3a2d8734647b9cc0ff4885b0b817c6ad

github.com

The name of the feature in Settings is 'Charging control', you can use Settings search feature, or find it listed in the main Settings->Battery page.

 

[Rrreutel]

I really want to get IodéOS working with the lates code, but it wont be happening unless someone can give me a clue how to go about fixing this build error. Pretty please...

Don't have a solution for your issue (and have never built IodéOS), but maybe this helps a step:

As your log shows, the failure occurs when running the checkvintf tool, invoked from check_target_files_vintf.py. The checkvintf tool is built from <root>/system/libvintf/check_vintf.cpp, its main() function is supposed to return 'compatible' (as it does with your other succesful builds). The invocation (the set of commandline parameters) is exactly as with the successful builds, so that's not the problem.

Error code 70 from your log means EX_SOFTWARE (as per sysexits.h: #define EX_SOFTWARE 70). This code is returned from checkvintf if it cannot determine either 'compatible' or 'incompatible'. You could check your log to see if it includes the error message from checkvintf which according to the check_vintf.cpp sourcecode should look like:

<log metadata like datetime>ERROR: <error code>: <some error description>

So search for "ERROR: " The <error code> might not be equal to 70 in this log line)

Maybe that error description gives some more info. Errors could include:
- No device HAL manifest
- Depricated HAL's
- Unused HAL's

 

[petefoth]

So search for "ERROR: " The <error code> might not be equal to 70 in this log line)

Maybe that error description gives some more info. Errors could include:
- No device HAL manifest
- Depricated HAL's
- Unused HAL's

That's it - the log contains this

Unable to print HALs from new FCMs: no device HAL manifest.
ERROR: No such device: No device manifest file from device or from update package
No device manifest.
No device HAL manifest: No such device

But before that we have

getDeviceHalManifest: -2147483648 VINTF parse error: Cannot add manifest fragment /vendor/etc/vintf/manifest/[email protected]: HAL "android.hardware.usb" has a conflict: Conflicting major version: 1.0 (from /vendor/etc/vintf/manifest/[email protected]) vs. 1.0 (from /vendor/etc/vintf/manifest/[email protected]). 
Check whether or not multiple modules providing the same HAL are installed.

And looking in `out/target/product/lilac/vendor/etc/vintf/manifest' there is an old file `[email protected]` from an earlier build alongside the current `[email protected]`

I'll clean up and rebuild - thanks for your help

 

[petefoth]

In order to get complete functionality you need to do 2 things before building:

1) pick the LOS HAL topic:
$ cd <LOS repo root dir>
$ repopick -t charging-control-hal-20

2) pick this PR from the whatawurst Yoshino-common device repo:

yoshino-common: Build lineage health HAL and related sepolicies by derfelot · Pull Request #97 · whatawurst/android_device_sony_yoshino-common

Change-Id: I1ca5f25f3a2d8734647b9cc0ff4885b0b817c6ad

github.com

The name of the feature in Settings is 'Charging control', you can use Settings search feature, or find it listed in the main Settings->Battery page.

Thanks for that. I make my LineageOS for microG builds using Docker. I could try and make a shell script to do all that before starting the build, but I think it's too complex for my shell coding skills, and I'd probably do it wrong anyway. The charging control functionality can wait util the code makes its way into the LOS and `yoshino-common` mainline code. (@Danko Jones - sorry - you'll have to wait )

 

[Danko Jones]

Thanks for that. I make my LineageOS for microG builds using Docker. I could try and make a shell script to do all that before starting the build, but I think it's too complex for my shell coding skills, and I'd probably do it wrong anyway. The charging control functionality can wait util the code makes its way into the LOS and `yoshino-common` mainline code. (@Danko Jones - sorry - you'll have to wait )

No problem.
Other than that I successfully dirty flashed the updated microg rom and it's working perfectly for now. Thanks again for your effort!

 

[petefoth]

That's it - the log contains this

Unable to print HALs from new FCMs: no device HAL manifest.
ERROR: No such device: No device manifest file from device or from update package
No device manifest.
No device HAL manifest: No such device

But before that we have

getDeviceHalManifest: -2147483648 VINTF parse error: Cannot add manifest fragment /vendor/etc/vintf/manifest/[email protected]: HAL "android.hardware.usb" has a conflict: Conflicting major version: 1.0 (from /vendor/etc/vintf/manifest/[email protected]) vs. 1.0 (from /vendor/etc/vintf/manifest/[email protected]).
Check whether or not multiple modules providing the same HAL are installed.

And looking in `out/target/product/lilac/vendor/etc/vintf/manifest' there is an old file `[email protected]` from an earlier build alongside the current `[email protected]`

I'll clean up and rebuild - thanks for your help

So my IodeOS build succeeded after cleaning up the `out/target/product/lilac/vendor/etc/vintf/manifest` directory. This is what I use on my daily driver so I flashed it and started using it.

However, after a few days use on my daily driver, I noticed that the battery performance is badly degraded with this IodeOS build. The previous build would easily last a whole day, even with quite heavy use, Typically with ~20% or 30% left when I put it on charge before going to sleep. This build is running down to ~10%-15% by late afternoon / early evening with only light use. With heavy use it is likely to run out sometime in the afternoon.

I really need my phone to last a whole day, so I 'downdated` to me previous build, which does not have the smart charging changes. ( I 'dirty flashed the old build over the newbuild with no problems. I was concerned that it might not work so I did a TWRP backup **and** backed up using ABRT before I dirty flashed, but it seems that was not necessary for me at least).

No problem.
Other than that I successfully dirty flashed the updated microg rom and it's working perfectly for now. Thanks again for your effort!

I would be interested to know if the latest Lineage for microG build has the same problem

 

[Danko Jones]

I would be interested to know if the latest Lineage for microG build has the same problem

Yes, I noticed the same with newest build. I wasn't sure if the problem was on my side. Thanks for letting me know. I'll also downgrade to previous version. Other than that everything has worked fine so far.

 

[Rrreutel]

So my IodeOS build succeeded after cleaning up the `out/target/product/lilac/vendor/etc/vintf/manifest` directory. This is what I use on my daily driver so I flashed it and started using it.

However, after a few days use on my daily driver, I noticed that the battery performance is badly degraded with this IodeOS build. The previous build would easily last a whole day, even with quite heavy use, Typically with ~20% or 30% left when I put it on charge before going to sleep. This build is running down to ~10%-15% by late afternoon / early evening with only light use. With heavy use it is likely to run out sometime in the afternoon.

I really need my phone to last a whole day, so I 'downdated` to me previous build, which does not have the smart charging changes. ( I 'dirty flashed the old build over the newbuild with no problems. I was concerned that it might not work so I did a TWRP backup **and** backed up using ABRT before I dirty flashed, but it seems that was not necessary for me at least).



I would be interested to know if the latest Lineage for microG build has the same problem

My personal build with microG (from May 16) is fine wrt battery.

 

[petefoth]

My personal build with microG (from May 16) is fine wrt battery.

That's useful to know - thanks. For now, I'm using my spare phone, running my previous build, as my main phone. I'm investigating the charging problem on my daily driver.

The current suspect is an update to Aperture: looking at Battery ussage showed it using a lot of battery, even though had hardly used it. on IodeOS, I use Iode's own build of Aperture from their F-Droid repo