Development [ROM][OFFICIAL][lemonadep][13] LineageOS 20

[osm0sis]

Anyone know why you can't sideload Magisk in recovery or even use twrp to install it? It freezes and does nothing? I patched the boot which is a alternative but it's longer that way.

Noticed this myself in TWRP. It also happens on Lineage Recovery? Wondering if it's the .capex files not being processed correctly by the installer. Even so it should fail more gracefully than hanging like that. I'm going to look into it.

Doesn't happen on my wife's 8T running PE Plus 13 on PE Recovery at least.

My workaround for now was to flash TWRP with TWRP, reboot to recovery, dump boot, boot to ROM and turn on airplane mode immediately (to not start failing SafetyNet/PlayIntegrity), patch the dumped boot in Magisk, reboot to recovery and flash the magisk_patched.img

 

[JSilver2021]

Correct. Very smooth upgrade experience without loosing any data on my device.

@roman_ant Did you flash Recovery also or just sideload first?

 

[Crazy_Fox]

Hi, Team!
Does anyone got crashes with "Settings -> Wallpaper and style" ?
PS: Upgraded from official LOS 19 w/o wiping Data

 

[MJPollard]

Hi, Team!
Does anyone got crashes with "Settings -> Wallpaper and style" ?
PS: Upgraded from official LOS 19 w/o wiping Data

Not to tell you how to do things on your own phone, but dirty flashing a major Android upgrade over the previous one (i.e. 19.1 to 20) has the potential to introduce all sorts of problems, from minor to major. This particular thing could be a symptom, but I couldn't say for sure.

 

[LuK1337]

Hi, Team!
Does anyone got crashes with "Settings -> Wallpaper and style" ?
PS: Upgraded from official LOS 19 w/o wiping Data

"com.android.wallpaper" crashing when trying to open in LOS 20 on OnePlus 9 Pro (#5371) · Issues · LineageOS / issues / android · GitLab

Expected Behavior The App to not crash Current Behavior After upgrade to...

gitlab.com

 

[xerves78]

Cool! How is Magisk working on the latest Android?

very good, no problems

 

[xerves78]

Not to tell you how to do things on your own phone, but dirty flashing a major Android upgrade over the previous one (i.e. 19.1 to 20) has the potential to introduce all sorts of problems, from minor to major. This particular thing could be a symptom, but I couldn't say for sure.

why are dirty flash not good ?
on stock roms upgrades never need a wipe data
why it is a problem on custom roms ?

 

[AnierinB]

AOD seems a little wonky on Lineage 20 with the full size double-line clock... Like it's offset too low on the screen, so it overlaps with the battery percentage overlay.

Also some apps like FX File Explorer aren't allowed to enable notifications (even though I had never disabled them in 19.1).

Haven't figured out any workarounds yet.


Edit: I've disabled double-line clock for now until the AOD offset gets fixed.

And turns out the disabled notifications issue is an Android 13 issue which some apps are afflicted with, but it can be fixed on the app side, per this MalwareBytes forum thread: https://forums.malwarebytes.com/topic/290668-android-13-blocking-notifications/

This is actually due to google's incomplete resolution switching implementation merged into AOSP 13 that affects any SystemUI resources set in px. I've written a DisplayUtil that gets the ratio for the max resolution vs the current resolution to counter it, but to apply that to so many resources in SystemUI is just not ideal. I submitted a change with my utility to AOSP master gerrit, which made google aware of this issue (they'll be taking a different approach) and am hoping it will be fixed with QPR2 or later.

For reference (link to the change on aosp gerrit is here as well):

https://review.lineageos.org/c/LineageOS/android_frameworks_base/+/344762

What you can do in the meantime is set your resolution to the max (1440) and the affected resources should be scaled properly.

 

[Crazy_Fox]

"com.android.wallpaper" crashing when trying to open in LOS 20 on OnePlus 9 Pro (#5371) · Issues · LineageOS / issues / android · GitLab

Expected Behavior The App to not crash Current Behavior After upgrade to...

gitlab.com

Thanks, re-adding Photo and Video permissions manually fixed the issue for me

 

[Psk.It]

Anyone know why you can't sideload Magisk in recovery or even use twrp to install it? It freezes and does nothing? I patched the boot which is a alternative but it's longer that way.

this should be done just once
on updating, just persist magisk from magisk manager
(as described here)

 

[osm0sis]

This is actually due to google's incomplete resolution switching implementation merged into AOSP 13 that affects any SystemUI resources set in px. I've written a DisplayUtil that gets the ratio for the max resolution vs the current resolution to counter it, but to apply that to so many resources in SystemUI is just not ideal. I submitted a change with my utility to AOSP master gerrit, which made google aware of this issue (they'll be taking a different approach) and am hoping it will be fixed with QPR2 or later.

For reference (link to the change on aosp gerrit is here as well):

https://review.lineageos.org/c/LineageOS/android_frameworks_base/+/344762

What you can do in the meantime is set your resolution to the max (1440) and the affected resources should be scaled properly.

Fantastic! Thanks for your work!

You're right, 1440p (then cranking up the Display size to compensate) gets things looking right again.

 

[osm0sis]

this should be done just once
on updating, just persist magisk from magisk manager
(as described here)

I've already confirmed it's broken right now and can't be done in TWRP at all, let alone just once (which I agree should be done on custom ROMs to install the addon.d script). You can copy in the addon.d script manually as /system/addon.d/99-magisk.sh for now. I'm going to see about looking into it today.

Edit: So far, I can confirm Lineage Recovery is unaffected, so it must be something different with TWRP's shell/mount/execution environment.

 

[Perceval from Hyrule]

Hi,
Just installed from a fresh LOS 19.1 I updated... a week - works perfect (I don't use the GApps anymore, I just sideloaded Magisk back). I'll report bugs if any.
Small question, is it useful to update the recovery ? I updated it before upgrading to 20, and the device became unbootable, so I reflashed the latest LOS 19.1 Recovery and everything ran fine.
I pushed back libjni_latinimegoogle.so to get the finger gestures on the AOSP keyboard (/system/product/app/LatinIME/lib/arm64), works great !

Thanks to all the devs and the community !!!

 

[Cmindo]

Is there a way to get the aperture app (new camera app) back without having to clean flash?

I uninstalled it using ADB shell but would like it back.

Perhaps there's an APK I can download?

 

[Perceval from Hyrule]

Is there a way to get the aperture app (new camera app) back without having to clean flash?

I uninstalled it using ADB shell but would like it back.

Perhaps there's an APK I can download?

I don't know if it will work, but here is my original apk (from /system/product/app/Aperture).
Check the owner (root) and permissions (0644), and if the oat dir is here (odex files)...
You can also extract from the ROM file using payload-dumper-go...

 

[MJPollard]

why are dirty flash not good ?
on stock roms upgrades never need a wipe data
why it is a problem on custom roms ?

Like I said, do what you like. If it works for you, fantastic. However, I've been doing this long enough to not trust dirty flashing a new major Android release over an older release (i.e. 12.1 to 13), because there's simply no guarantee that something between major releases hasn't changed significantly to mess something up. (I also don't split two 10s while playing blackjack, because I'm not about to take the chance of throwing away the third best hand you can have, and a good chance of beating the dealer, for possibly two lesser ones that could bust and lose twice the money.)

 

[roman_ant]

@roman_ant Did you flash Recovery also or just sideload first?

I did install latest 19.1 build first, then sideloaded new lineageos build. Recovery was updated automatically ...

 

[der_akinator]

Noticed this myself in TWRP. It also happens on Lineage Recovery? Wondering if it's the .capex files not being processed correctly by the installer. Even so it should fail more gracefully than hanging like that. I'm going to look into it.

Doesn't happen on my wife's 8T running PE Plus 13 on PE Recovery at least.

My workaround for now was to flash TWRP with TWRP, reboot to recovery, dump boot, boot to ROM and turn on airplane mode immediately (to not start failing SafetyNet/PlayIntegrity), patch the dumped boot in Magisk, reboot to recovery and flash the magisk_patched.img

Strange bug. I have noticed that magisk installation works if TWRP is booted with "fastboot boot boot.img", but I have no clue why it doesn't work if it's booted from device.

 

[osm0sis]

Strange bug. I have noticed that magisk installation works if TWRP is booted with "fastboot boot boot.img", but I have no clue why it doesn't work if it's booted from device.

So far I've narrowed it down to the Magisk busybox losetup as part of mounting apex hangs the entire shell the very first time it's run on /dev/block/loop0, which normally would just fail and trigger iteration up to the next (and next, until unused) loop# since 0 and other lower loops are often already in use.

Interesting that it's related to boot state, and works with Lineage Recovery flashed but not TWRP, considering all the commands are run in Magisk's busybox ash with Magisk's busybox commands either way.

Edit: I just remembered a potentially connected issue from my notes testing twrp-11 on my 9 Pro, where `mount -o loop` commands fail only when TWRP is fastboot boot'd; sort of the opposite of what we're seeing now boot state wise, and the command only failed, didn't hang the whole shell.

Edit 2: Follow up in the TWRP thread: https://forum.xda-developers.com/t/...ryption-support.4523857/page-14#post-87951761

 

[kjslabber]

I tried to sideload magisk using twrp. It appeared to install correctly but after rebooting to system magisk didn't appear installed in magisk manager. I prepared to patch the boot image, when I went to patch the image file in manager the option to direct install was available. I installed using direct install and rebooted. Got root. Very strange. I'm on LE2125, using magisk 25.2. All is good. I have twrp installed on phone.