[ROM][OMS7][Experimental]LineageOS 14.1 with extra open commits

[matssa]

cd to your BUILD_DIR/vendor/oneplus
and show output of

git status

and

git log -n 3

For the git status:

[email protected]:~/android/system/device/oneplus/oneplus3$ git status
HEAD detached from 52b5d7a
nothing to commit, working directory clean

For the log:

[email protected]:~/android/system/device/oneplus/oneplus3$ git log -n 3
commit d2fd4573dc24dc69911c2cd9af187889d27ff99a
Author: dianlujitao <[email protected]>
Date:   Sat Dec 3 15:24:11 2016 +0800

    op3: Stop preloading libNimsWrap.so
    
    Change-Id: I8af0fb691a44e383d47bc70c132b7bf9cdfe83f9

commit cf697f5c25b861b71c8a0e007d39295ca25e710e
Author: dianlujitao <[email protected]>
Date:   Sun Dec 4 19:48:22 2016 +0800

    op3: Add net_raw group to ril-daemon
    
     * Our ril blobs need it.
    
    Change-Id: I46503d456c9ebf6b58ce96303cc3ec7317d99179

commit 883c8991dc672f8c8d432e7fcd4b999bef133aca
Author: dianlujitao <[email protected]>
Date:   Sun Dec 4 13:46:17 2016 +0800

    op3: Build libgnsspps.so
    
    Change-Id: I552fd1a678e48f676e24836ccee4cbb97ad5465c

With my latest build, I have the same issue now, the dev settings won't open I don't know why my first build was NOK...

 

[ivanich]

For the git status:

[email protected]:~/android/system/device/oneplus/oneplus3$ git status
HEAD detached from 52b5d7a
nothing to commit, working directory clean

For the log:

[email protected]:~/android/system/device/oneplus/oneplus3$ git log -n 3
commit d2fd4573dc24dc69911c2cd9af187889d27ff99a
Author: dianlujitao <[email protected]>
Date:   Sat Dec 3 15:24:11 2016 +0800

    op3: Stop preloading libNimsWrap.so
    
    Change-Id: I8af0fb691a44e383d47bc70c132b7bf9cdfe83f9

commit cf697f5c25b861b71c8a0e007d39295ca25e710e
Author: dianlujitao <[email protected]>
Date:   Sun Dec 4 19:48:22 2016 +0800

    op3: Add net_raw group to ril-daemon
    
     * Our ril blobs need it.
    
    Change-Id: I46503d456c9ebf6b58ce96303cc3ec7317d99179

commit 883c8991dc672f8c8d432e7fcd4b999bef133aca
Author: dianlujitao <[email protected]>
Date:   Sun Dec 4 13:46:17 2016 +0800

    op3: Build libgnsspps.so
    
    Change-Id: I552fd1a678e48f676e24836ccee4cbb97ad5465c

With my latest build, I have the same issue now, the dev settings won't open I don't know why my first build was NOK...

I asked you to show git output of vendor/oneplus and nod device/oneplus

 

[matssa]

I asked you to show git output of vendor/oneplus and nod device/oneplus

Woops soz, here is the stuff you asked.

HEAD detached at 481d05a
nothing to commit, working directory clean

[email protected]:~/android/system/vendor/oneplus$ git log -n 3
commit 481d05a4c8b09d3985361186104df3afd62f13f5
Author: dianlujitao <[email protected]>
Date: Sun Dec 4 11:23:04 2016 +0800

op3: Update to official N blobs

* From Open Beta 8
* qti-telephony-common.jar from gemini
* Keep M camera blobs

commit d9d97712e93b9a781f260a2f4b696910ac9b123b
Merge: 13a5372 72fd3d8
Author: Ethan Chen <[email protected]>
Date: Sun Nov 27 17:52:52 2016 -0800

Merge pull request #51 from jfeise/cm-14.1

Binary blob to enable full-disk decryption.

commit 72fd3d862ba7e0f60779709f686b307cf6d9b930
Author: J. Joe Feise <[email protected]>
Date: Mon Nov 21 08:17:18 2016 -0800

Remove unused file.

 

[ivanich]

Woops soz, here is the stuff you asked.

HEAD detached at 481d05a
nothing to commit, working directory clean

[email protected]:~/android/system/vendor/oneplus$ git log -n 3
commit 481d05a4c8b09d3985361186104df3afd62f13f5
Author: dianlujitao <[email protected]>
Date: Sun Dec 4 11:23:04 2016 +0800

op3: Update to official N blobs

* From Open Beta 8
* qti-telephony-common.jar from gemini
* Keep M camera blobs

commit d9d97712e93b9a781f260a2f4b696910ac9b123b
Merge: 13a5372 72fd3d8
Author: Ethan Chen <[email protected]>
Date: Sun Nov 27 17:52:52 2016 -0800

Merge pull request #51 from jfeise/cm-14.1

Binary blob to enable full-disk decryption.

commit 72fd3d862ba7e0f60779709f686b307cf6d9b930
Author: J. Joe Feise <[email protected]>
Date: Mon Nov 21 08:17:18 2016 -0800

Remove unused file.

Looks correct, broken dev settings confirms this

 

[matssa]

Looks correct, broken dev settings confirms this

Yup I'm trying to merge the commit https://github.com/scotthartbti/and...d05#diff-2339e3716d18484a6a228578cff1f8beR725 that should hax the dev settings in order to use them (removes the OEM unlock feature and the screen stay on while charging feature), but I get some issues while merging:

[email protected]:~/android/system/packages/apps/Settings$ git status
HEAD detached at e6ca00a
You are currently cherry-picking commit 158ed6f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:

	modified:   res/xml/development_prefs.xml

Unmerged paths:
  (use "git add <file>..." to mark resolution)

	both modified:   src/com/android/settings/DevelopmentSettings.java

When I check the files that is both modified, I can see the <<<<< HEAD and some code afterwards, but the problem is that the coding between the headers is different from what I can see on Github (i.e. i see some extra stuff concerning Bugreport). I removed manually the correct stuff and didn't change the extra stuff.
Do you think that my process is logic? Furthermore, do I need to do the manual changes every time I will repo sync? Another way would be to sync it with my Github...

Thanks for your help

 

[ivanich]

Yup I'm trying to merge the commit https://github.com/scotthartbti/and...d05#diff-2339e3716d18484a6a228578cff1f8beR725 that should hax the dev settings in order to use them (removes the OEM unlock feature and the screen stay on while charging feature), but I get some issues while merging:

[email protected]:~/android/system/packages/apps/Settings$ git status
HEAD detached at e6ca00a
You are currently cherry-picking commit 158ed6f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:

	modified:   res/xml/development_prefs.xml

Unmerged paths:
  (use "git add <file>..." to mark resolution)

	both modified:   src/com/android/settings/DevelopmentSettings.java

When I check the files that is both modified, I can see the <<<<< HEAD and some code afterwards, but the problem is that the coding between the headers is different from what I can see on Github (i.e. i see some extra stuff concerning Bugreport). I removed manually the correct stuff and didn't change the extra stuff.
Do you think that my process is logic? Furthermore, do I need to do the manual changes every time I will repo sync? Another way would be to sync it with my Github...

Thanks for your help

It means that file has been changed by another commit, fix conflicts and commit change. After that you can save this commit as a patch by "git format-patch -1" and then you can apply this patch in your ROM build script like this

cd packages/apps/Settings
git am /path_to_your_patch
cd -

 

[ivanich]

I found a much more simple workaround for dev settings freeze
just comment out or delete from build.prop

ro.frp.pst=/dev/block/bootdevice/by-name/config

 

[bay91]

What issues do you have? Do you have the same issues with the official nightly without the extra blobs? If so, can you please give us some logs?

I've had the same issues as reported regarding the home button behaviour, as I posted on page 1. Logs? Well I've flashed back to 14.1 official for now

 

[matssa]

I've had the same issues as reported regarding the home button behaviour, as I posted on page 1. Logs? Well I've flashed back to 14.1 official for now

Ah didn't see, but this means that the issue is only on the experimental build, not on the official builds, which meeeans that this issue came from N blobs, just as I feared. I don't have any solution, might need to wait until official OOS for N gets out, or maybe check the blobs in Beta 9. Other idea is that it can come from kernel, which will be delivered before the end of the year i hope.

 

[Jole7]

Ah didn't see, but this means that the issue is only on the experimental build, not on the official builds, which meeeans that this issue came from N blobs, just as I feared. I don't have any solution, might need to wait until official OOS for N gets out, or maybe check the blobs in Beta 9. Other idea is that it can come from kernel, which will be delivered before the end of the year i hope.

What about previous firmware 3.2.8? I have zero issues with it

 

[matssa]

What about previous firmware 3.2.8? I have zero issues with it

Ah you are talking about the Old M firmware or the firmware from OOS beta? The new firmware should be included in the zip that I share, so you may need to flash the old firmware after flashing the ROM to be sure.

So the home button bug isn't present on your system?

 

[Jole7]

Ah you are talking about the Old M firmware or the firmware from OOS beta? The new firmware should be included in the zip that I share, so you may need to flash the old firmware after flashing the ROM to be sure.

So the home button bug isn't present on your system?

Yes i mean about the M firmware no such problems here

 

[matssa]

Yes i mean about the M firmware no such problems here

Ok, we may need to test it with the new OOS beta 9 firmware. I understand that it works with M, but we may break something with the old firmware, especially with the new blobs. You can stay with the old firmware if it works, but I'm still a little bit surprised ^^ anyways, thanks for the info!

 

[Jole7]

Ok, we may need to test it with the new OOS beta 9 firmware. I understand that it works with M, but we may break something with the old firmware, especially with the new blobs. You can stay with the old firmware if it works, but I'm still a little bit surprised ^^ anyways, thanks for the info!

No problem great rom

 

[Pumpino]

Thanks for your work. Can I ask why CM is not integrating the Nougat blobs like you are? Wouldn't this assist with the fingerprint scanner issues and with improving camera quality?

 

[Tikerz]

Thanks for your work. Can I ask why CM is not integrating the Nougat blobs like you are? Wouldn't this assist with the fingerprint scanner issues and with improving camera quality?

I'm guessing because Nougat hasn't been officially released by OnePlus.

Sent from my ONEPLUS A3000 using Tapatalk

 

[matssa]

Thanks for your work. Can I ask why CM is not integrating the Nougat blobs like you are? Wouldn't this assist with the fingerprint scanner issues and with improving camera quality?

Since OOS Nougat is still in beta testing, I think that @dianlujitao is waiting until we have the official blobs. Furthermore, when the kernel is released, we will have some bugs that will be fixed, and a better battery life I hope.

Furthermore, there may be some bugs that are being fixed, but I don't see much activity... Best guess is to wait and see how it goes, I don't know if Beta 9 brought some stuff for us, I don't have enough time nor knowledge

 

[ivanich]

Since OOS Nougat is still in beta testing, I think that @dianlujitao is waiting until we have the official blobs. Furthermore, when the kernel is released, we will have some bugs that will be fixed, and a better battery life I hope.

Furthermore, there may be some bugs that are being fixed, but I don't see much activity... Best guess is to wait and see how it goes, I don't know if Beta 9 brought some stuff for us, I don't have enough time nor knowledge

Actually there is no activity at all, just look how it goes with xiaomi_gemini for example, bruno realy doing his work. And we stuck because op3 have no active maintainer.

Отправлено с моего ONEPLUS A3000 через Tapatalk

 

[matssa]

Actually there is no activity at all, just look how it goes with xiaomi_gemini for example, bruno realy doing his work. And we stuck because op3 have no active maintainer.

Отправлено с моего ONEPLUS A3000 через Tapatalk

True, there isn't any activity, at least in public. I thought the active maintainer was @dianlujitao? There was Steve that was helping out since he has a 1+3 special edition, but since he got canned, there isn't any stuff going around... I hope everything will be back on track when LineageOS get's out (new ROM from Steve apparently...).

What is so strange is that the 1+3 is a great phone, with a lot of dev possibilities with the extra information that is given by OnePlus, kinda like a dev phone without any dev working on it or with it ^^' Or maybe not for CM, maybe some other custom ROMs are working on it...

 

[chazey2]

Feel free to give me your feedback!

Ok few days in and dirty flashed up to your latest build.

Background:
Beta 9 Firmware and Modem
Boeffla Beta 6 Kernel
Super SU 2.78-SR5
Apex Pro launcher

Phone mainly used for business use lots emails, calls and txt
Approximately hour and half google maps navigation daily.
Bit of music listening and browsing.
Phone spends up to 10 hours daily in workplace with no radio/data signal- not on Airplane mode as need WiFi for email.

No games installed or social apps.

Battery for me very good under the above conditions all phone operations and UI slick, swift and smooth with no glitches.
Apart from Dev Options glitch I haven't noticed any other problems in my day to day use. (I can't find the entry in build.prop quoted to delete to fix)??
I have my long press home set to 'search' no issues.
FP works for me every time first time!