[ROM][SNAPSHOT][7.1] LineageOS 14.1 for Xperia SP

[AdrianDC]

@AdrianDC, I just noticed that the cgroups are not populated. There is no cgroup/cpuset for background tasks, foreground tasks etc. (therefore Android task scheduling might not work properly)

Those are on /dev/cpuctl and /dev/cpuset (I don't know if Android uses /sys/fs/cgroup but it also contains nothing)

I don't know if it is a bug but, maybe this needs to be reported just in case ^_^

Not a bug, CPUSET is not implemented by the kernel.

 

[AdrianDC]

Quite an important change... That you might want to have a look at.. Maybe...
https://xdaforums.com/xperia-sp/ori...-xperia-sp-t3449300/post73049970#post73049970

 

[X7SHaDe]

Not a bug, CPUSET is not implemented by the kernel.

Are there any plans of implementing it?

 

[AdrianDC]

Are there any plans of implementing it?

No.
CPUSETS is known to have a negative impact on performance, especially in concern with the CPU hotplugging.
Let's not introduce a potential random issue source on something that works just fine and is stable on 3.4.113 .

 

[dimenfer]

Quite an important change... That you might want to have a look at.. Maybe...
https://xdaforums.com/xperia-sp/ori...-xperia-sp-t3449300/post73049970#post73049970

WOW, nice job on that, sadly I don't have an SP more [emoji22]

Sent from my Xperia ZL using Tapatalk

 

[X7SHaDe]

No.
CPUSETS is known to have a negative impact on performance, especially in concern with the CPU hotplugging.
Let's not introduce a potential random issue source on something that works just fine and is stable on 3.4.113 .

Are you sure that you did not just forget to set "/dev/cpuset/*/cpus" to 0-1?

 

[Daedroza]

Are you sure that you did not just forget to set "/dev/cpuset/*/cpus" to 0-1?

This is pretty much useless. You can set it manually on-early boot as soon as the virtual fs /dev is populated if it makes any difference for you. The original implementation was for post-2015, pre-2016 devices which were shipping the long term 3.10 kernel along with cpuset implemented in it of-course.

However, it is reverted (at least in Sony Open Source Projects), it's useless, causes mess with SUSPEND.

Not to mention, it is pointless to port this on 1G RAM, dual-core processor since the amount of computation required for calculation of proper placing of tasks on processor is not that great, because there are just 2 cores present.

Kernel can easily schedule tasking on the two cores, it way better than implementing / backporting the full cpuset.

Not to mention, cpuset divides the main memory in distinct memory banks for processes. Doing this on 1GB RAM device with Android Apps running is not a practical idea because of constant memory fragmentation.

The only thing that Qualcomm has forwarded with cgroups is the implementation of cpu.notify_on_migrate that requires proper cgroups, which is already present on many of the Sony devices.

 

[AdrianDC]

New release July 19 includes my lights effects implementation presented here : https://xdaforums.com/xperia-sp/ori...-xperia-sp-t3449300/post73049970#post73049970

 

[26didi89]

I am impressed to see new functionnalities being included in your ROMs so many years after Xperia SP release.
Good job Adrian!

 

[NyQuilXT]

New release July 19 includes my lights effects implementation presented here :https://xdaforums.com/xperia-sp/ori...-xperia-sp-t3449300/post73049970#post73049970

Thank you so much for all your efforts you put into the development for this device!!!
I've tried the Lights effects feature and noticed that also the audio output stops, when the screen turns off while playing music with lights effects turned on and "only pulse with display on" activated. Anyone else too? (tested with 3rd party music players like AIMP etc)

 

[ervinakoc x]

New release July 19 includes my lights effects implementation presented here : https://xdaforums.com/xperia-sp/ori...-xperia-sp-t3449300/post73049970#post73049970

Thanks again for the job! Can you do something like that when you change the photos? The pre-cursed white light when it sounds like a sound when it hits your cell and calls you can be changed; Thanks:good:

 

[AdrianDC]

Thank you so much for all your efforts you put into the development for this device!!!
I've tried the Lights effects feature and noticed that also the audio output stops, when the screen turns off while playing music with lights effects turned on and "only pulse with display on" activated. Anyone else too? (tested with 3rd party music players like AIMP etc)

My LightsEffectsService only listens to the media service events, it does not trigger play / pause commands.

It would be good that you first test / confirm you have an issue by completely disabling the lights_effects with the main switch,
then see with the awake option on and off if anything changes.

As a guess, right now all I can think off would be that the app itself has an issue interacting with display on / off situations.
I would also like to invite you to test with other music apps, especially with the default LineageOS' music player Eleven.
I tested with Eleven, Sony Music and a few other apps.

Thanks again for the job! Can you do something like that when you change the photos? The pre-cursed white light when it sounds like a sound when it hits your cell and calls you can be changed; Thanks:good:

Thanks.
No I did not and do not intend to do that, because unlike music where I implemented it through a complicated registering into the media services
to know when a random music player starts / pauses / stops / get cover artwork, images are statically handled inside the application,
hence rely only on the app and no interaction is done with services to tell an image is being shown or its contents (that would be bad).

Therefore it would need me to modify and implement that on the Gallery app directly, which is not good when it concerns only 1 device from all LineageOS maintained devices,
and would also mean I would get random request of adding that or that application to support the feature,
which is exactly why I avoided for music players with the way I coded it with the media service.

 

[NyQuilXT]

My LightsEffectsService only listens to the media service events, it does not trigger play / pause commands.

It would be good that you first test / confirm you have an issue by completely disabling the lights_effects with the main switch,
then see with the awake option on and off if anything changes.

As a guess, right now all I can think off would be that the app itself has an issue interacting with display on / off situations.
I would also like to invite you to test with other music apps, especially with the default LineageOS' music player Eleven.
I tested with Eleven, Sony Music and a few other apps.

I don't mean any play/pause events - the audio output itself is interrupted..the player itself keeps playing...turning back on the screen...the audio output continues...
Same thing when disabling/enabling the lights effects feature in the settings menu while playing music with some 3rd party players...(tested with AIMP, Yo!tuner, Soundcloud)

Only Eleven is working fine there...and...well DI.FM radio app

 

[ervinakoc x]

One more thing! Vpn programs why do not they ever work? Just in stock! It's easy to make it work; Again, thank you for your time

 

[AdrianDC]

I don't mean any play/pause events - the audio output itself is interrupted..the player itself keeps playing...turning back on the screen...the audio output continues...
Same thing when disabling/enabling the lights effects feature in the settings menu while playing music with some 3rd party players...(tested with AIMP, Yo!tuner, Soundcloud)

Only Eleven is working fine there...and...well DI.FM radio app

Alright that's interesting thanks.

I think I know what's happening : Out of the 5 audio routes needed for Lights Effects, there's only one that is also used for something else,
for the low-latency mixer used by some audio situations like the ones you used, unlike the deep-buffer mixer that is not related to these.

I'll look into it and figure a way around that when possible.

One more thing! Vpn programs why do not they ever work? Just in stock! It's easy to make it work; Again, thank you for your time

I never use VPN and therefore can't really test it for now, last time I did nothing relevant popped out.
As far as I know, apps like FlashVPN work just fine, hence VPN is fine from my point of view.

If some really use and need VPN, I'd invite them to look into it and try to figure out a fix / potential reason,
because I cannot do everything, especially for things that I am not concerned with hence can't work on myself.

Also be aware that (with lights_effects being 'almost' over) my main focus comes back to AOSP 8.0 Master (as pointed out by some already).

 

[Majid.s]

Notification light

Thanks For this perfect Rom

Notification light> Use custom values , not works for me.
I set missed call to shows red color but That's show default color.

Thanks Again.

 

[ervinakoc x]

Also be aware that (with lights_effects being 'almost' over) my main focus comes back to AOSP 8.0 Master (as pointed out by some already).

I look forward to it and how it comes out

 

[AdrianDC]

I don't mean any play/pause events - the audio output itself is interrupted..the player itself keeps playing...turning back on the screen...the audio output continues...
Same thing when disabling/enabling the lights effects feature in the settings menu while playing music with some 3rd party players...(tested with AIMP, Yo!tuner, Soundcloud)

You will find a zip for lights_effects in the Development downloads,
which includes the fix that should 99% sure resolve the issue your experienced.

If I'm right, it's because one of the audio routes I used to set for lights_effects,
(in fact the only one that collides with the normal audio routes from the mixer_paths),
was in fact not _required_ for the audio to reach the AS3665 LEDs controller.
Therefore it is useless to enable / disable it and by the same time override it when it's already in use.

 

[abhishek2945]

after flashing ZIP file . i didn't get any settings for light effect ..??

 

[NyQuilXT]

You will find a zip for lights_effects in the Development downloads,
which includes the fix that should 99% sure resolve the issue your experienced.

What a nice wakeup present Awesome, the fix did it! Thank you very much for fixing the issue so quick!