@ripee, thanks for bringing LOS17.1 to the Tab S2. I know several times you said it's not very stable at all / that it's buggy (though that was weeks/months back), but it's been running great here on my friend's SM-T813. Definitely breathed a whole new life into this device. Looks like we picked a good time to mod his tablet.. this ROM seems to have stabilized quite a bit since its initial release based on reading previous posts.
The OP contained pretty much every hiccup to expected - the need to force reboot after clean flash (updating ROM afterwards just updated like normal), and the camera only semi-working (10-15 sec delay but works after), which is a complete non-issue to us. Using Google Camera app that comes with OpenGapps Stock.
Updated to 02-21-2021 build (pitrus)
Magisk 22.0
LSposed 0.5.4.1 (5175) - only module is GravityBox Q
No need to use MagiskHidePropsConfig (which you mentioned before anyway), SafetyNet passes after a Play Store data clear as expected.
Other than the permissive kernel and camera issue, the ROM has been really solid. Great work and thank you! Looking forward to its continued development.
There's just one thing though that I wanted to ask,
@ripee: I just can't seem to disable (nor reassign!!) the hardware capacitive keys. I'm really confused and lost here. I enabled the navigation bar with GravityBox (since it looks like you omitted the option in your ROM, which is fine) and disabled the button backlight. I tried modifying the generic.kl keyboard layout file but it doesn't work. What's even weirder is that using any button remapper app, including flar's with root access, doesn't seem to work either - and none of them successfully remap for both the navbar AND capacitive buttons. It's almost like they're being mapped differently at a much lower level... would you happen to have any clue as to where else to look? Really hate the hardware / capacitive buttons. Not even necessary to fully disable them, but at least swap them so it matches the layout of the navbar sitting right above them haha. Not even asking if you could commit the feature into the ROM. If I knew what to change, I could probably just make a Magisk module for it or something. Thanks!
Edit: The reason why the soft and hard keys were "linked" the way I described before, turned out to be due to GravityBox and the way it's designed as a whole, i.e. unfortunately simply disabling Navigation Bar tweaks master switch in GravityBox doesn't work. If I disable GravityBox entirely and enable Navigation Bar via qemu.hw.mainkeys=0, then the hardware keys can be remapped independently of the on-screen navbar (simply using Swap Back / Recents keys option in flar2's Button Mapper app, which at least puts the buttons and their corresponding actions right above/below each other). Unfortunately, GravityBox is necessary for me, haha. So I'm back to needing to simply be able to disable the hardware keys, which would basically fulfill all my "goals"... gonna keep tweaking around. =)
Edit2: Ok, now I feel dumb. It was in /vendor/usr/keylayout/sec_touchkey.kl -NOT- in /system/usr/keylayout/****.kl. I literally searched for all instances of BACK and APP_SWITCH, commented the lines, and pushed every .kl back to system, and nothing would work. Didn't think to look under /vendor/... **facepalm!!!**. I restored all the original files and now I have on-screen navigation bar, hardware navigation keys fully disabled (or swapped!), and GravityBox goodness all working together. =)