[ROM][UNOFFICIAL][12L][EAS][SM-T820][SM-T825][2022-09-23] LineageOS 19.1 for Galaxy Tab S3

Search This thread
I'm also interested in this question. Running with selinux=permissive is high risk, and it seems irresponsible that such a large proportion of unofficial ROMs disable selinux. LineageOS makes it mandatory to run selinux in enforcing mode in their official ROMs for good reason.

With selinux disabled, it is trivial for malicious code in an app to permanently root the device and gain full control over it, giving malicious actors the ability to access and exploit your personal information that exists within your other apps or perform other malicious activity without the user knowing. Given that there is a PoC on github that shows how to do this, you can bet that this exploit is already out in the wild.

@Awesometic, I appreciate and respect that you put a lot of your personal time and effort into this (it's a lot more than I do), but I think this concern is valid. Can you eli5 why you haven't set selinux=enforcing in your builds, and if it is possible, what it would take to achieve this?

Hello,

You're right, SELinux permissive is not safe from hacking. I know why making it enforce is important, but the reason is the time for sure.

As the main purpose of this development is to make the tablet usable again, SELinux enforcing is not a priority one since we all know the SELinux job takes so much time while that is not that important for normal use of the tablet.

So for now I wouldn't say that I will do that job in the future. 😅
 
The new version of LineageOS 19 is uploaded now.

This version has upstream LineageOS changes that comes with Android 12.1 r22, and a fix for Keystore to use hardware encryption in Samsung way properly.

In the first LineageOS 19.1 version, it uses some special files from the other partition but for some reason, it broke the boot sequence because of the delay and the permission issues. So I broke the loading of that special files and it would fix that boot failure problem.

Now, thanks to @masdaster , I can fix the boot failure and finally we can use the proper hardware encryption.

Thank you, and please note that the changelogs to fix the lock screen issue caused by changing the Keystore method.
 
Will a dirty flash work? Or is a clean flash mandatory?
I assume that the changes are to big for a dirty flash.
For me it mostly worked to flash cleanly and restore data afterwards.

Edit: dirty flash worked but some apps don't work properly or at all, so now I'm installing cleanly.
Edit2: clean + restoring worked, although (until now) one app had to be reinstalled.
 
Last edited:

MachineMasher

Member
Sep 8, 2021
25
12
I got lineage-19.1-20220815-UNOFFICIAL-gts3lwifi.zip installed successfully with my modified version of FlameGApps-12.1-basic-arm64-20220612.zip (modified per this post: https://forum.xda-developers.com/t/...-19-1-for-galaxy-tab-s3.4418855/post-87020709).

I'm still having the issue with the green bar in Zoom (per https://forum.xda-developers.com/t/...-18-1-for-galaxy-tab-s3.4293069/post-86517463). One additional thing that I noticed, though, is that in addition to having the distorted colours in Zoom, I also don't have any microphone sound even after enabling microphone and connecting audio with WiFi.

The Zoom microphone sound issue also happened in lineage-19.1-20220611-UNOFFICIAL-gts3lwifi.zip. Not sure about versions earlier than that.
 
Will a dirty flash work? Or is a clean flash mandatory?
I assume that the changes are to big for a dirty flash.
For me it mostly worked to flash cleanly and restore data afterwards.

Edit: dirty flash worked but some apps don't work properly or at all, so now I'm installing cleanly.
Edit2: clean + restoring worked, although (until now) one app had to be reinstalled.

Dirty flash will work but as @bmwdroid said it might break some apps that use any lock method.
It can be fixed by removing the '/data/system/locksettings.db' file, but still, the best way is the clean installation.

I got lineage-19.1-20220815-UNOFFICIAL-gts3lwifi.zip installed successfully with my modified version of FlameGApps-12.1-basic-arm64-20220612.zip (modified per this post: https://forum.xda-developers.com/t/...-19-1-for-galaxy-tab-s3.4418855/post-87020709).

I'm still having the issue with the green bar in Zoom (per https://forum.xda-developers.com/t/...-18-1-for-galaxy-tab-s3.4293069/post-86517463). One additional thing that I noticed, though, is that in addition to having the distorted colours in Zoom, I also don't have any microphone sound even after enabling microphone and connecting audio with WiFi.

The Zoom microphone sound issue also happened in lineage-19.1-20220611-UNOFFICIAL-gts3lwifi.zip. Not sure about versions earlier than that.

Yeah I know there is a malfunction in the Zoom app, but I think it is quite hard to fix. 😅
The suspicious thing I think is the camera implementation on our device tree, but we have to use the old Samsung camera binaries due to some changes of Samsung in HAL and kernel.
Or, there may be a kind of quick magic for fixing this thing, but I don't know yet..
 

martinedu

Member
Dec 18, 2010
16
2
Hello. I just installed the new version of the firmware but I run into a problem. When unlocking the tablet by entering the corresponding PIN, it asks me again to complete the PIN for unlocking. I tried to install the previous version of the firmware but again it behaves the same. Does anyone know a solution that does not perform a factory reset? From already thank you very much.
 
  • Like
Reactions: 908070
Hello. I just installed the new version of the firmware but I run into a problem. When unlocking the tablet by entering the corresponding PIN, it asks me again to complete the PIN for unlocking. I tried to install the previous version of the firmware but again it behaves the same. Does anyone know a solution that does not perform a factory reset? From already thank you very much.
that's somewhat peculiar as on my dirty flash it didn't ask.
Hope you made a TWRP backup of Data as I doubt you'll have a chance otherwise.
 
  • Like
Reactions: martinedu

martinedu

Member
Dec 18, 2010
16
2
My bad operation. I forgot to make a backup of the tablet. Install everything as if it just came out of the box.
 

908070

Member
May 26, 2020
9
1
Dirty flash will work but as @bmwdroid said it might break some apps that use any lock method.
It can be fixed by removing the '/data/system/locksettings.db' file, but still, the best way is the clean installation.



Yeah I know there is a malfunction in the Zoom app, but I think it is quite hard to fix. 😅
The suspicious thing I think is the camera implementation on our device tree, but we have to use the old Samsung camera binaries due to some changes of Samsung in HAL and kernel.
Or, there may be a kind of quick magic for fixing this thing, but I don't know yet..
Please write an info text on the start page of thread, if a clean installation is necessary. Dirty-Installation denies access after PIN entry.
 
Last edited:
My bad operation. I forgot to make a backup of the tablet. Install everything as if it just came out of the box.
Sorry to hear that. Perhaps it's worth a try:
backup Data as it's probably still untouched.
then:
1. just wipe System and flash new ROM and Gapps -> test it
2. to do 1 and wipe internal storage as well before flashing ROM and Gapps -> test it
if these two still don't work i think you will have to make a clean install.
Then try if restoring data makes it work again.
 
  • Like
Reactions: martinedu

martinedu

Member
Dec 18, 2010
16
2
Sorry to hear that. Perhaps it's worth a try:
backup Data as it's probably still untouched.
then:
1. just wipe System and flash new ROM and Gapps -> test it
2. to do 1 and wipe internal storage as well before flashing ROM and Gapps -> test it
if these two still don't work i think you will have to make a clean install.
Then try if restoring data makes it work again.
In the end I chose to perform a clean installation.
I also use the tablet for multimedia and the occasional game/social network before going to sleep.
Regardless of my problem, it is a great job that they are doing with this ROM.
I ended up convincing myself that it was not necessary to renew it.
 

castoruser

Member
Apr 8, 2021
9
1

Hello @Awesometic ;

thanks for your great work on this tablet also on Android 12.

I tried to build myself again and got always this error with the kernel by round about 57%:

I have tried your trick for Android 11 but it didn't work. What is your trick for Android 12?

thanks for your support.

greets

Castoruser
 

masdaster

Senior Member
Hello @Awesometic ;

thanks for your great work on this tablet also on Android 12.

I tried to build myself again and got always this error with the kernel by round about 57%:

I have tried your trick for Android 11 but it didn't work. What is your trick for Android 12?

thanks for your support.

greets

Castoruser
Hello,
do you have an error message, please? I have several 'fixes'/patches applied at the moment. 4 of them are critical and my build fails if I revert them...
 

castoruser

Member
Apr 8, 2021
9
1
Code:
hardware/qcom-caf/msm8996/audio/hal/audio_extn/utils.c:2523:2: error: invalid pr
eprocessing directive
#void audio_extn_utils_release_snd_device(snd_device_t snd_device)
 ^
hardware/qcom-caf/msm8996/audio/hal/audio_extn/utils.c:2524:2: error: invalid pr
eprocessing directive
#{
 ^
hardware/qcom-caf/msm8996/audio/hal/audio_extn/utils.c:2525:6: error: invalid pr
eprocessing directive
#    audio_extn_dev_arbi_release(snd_device);
     ^
hardware/qcom-caf/msm8996/audio/hal/audio_extn/utils.c:2526:6: error: invalid pr
eprocessing directive
#    audio_extn_sound_trigger_update_device_status(snd_device,
     ^
hardware/qcom-caf/msm8996/audio/hal/audio_extn/utils.c:2527:38: error: invalid p
reprocessing directive
#                                    ST_EVENT_SND_DEVICE_FREE);
                                     ^
hardware/qcom-caf/msm8996/audio/hal/audio_extn/utils.c:2528:6: error: invalid pr
eprocessing directive
#    audio_extn_listen_update_device_status(snd_device,
     ^
hardware/qcom-caf/msm8996/audio/hal/audio_extn/utils.c:2529:38: error: invalid p
reprocessing directive
#                                    LISTEN_EVENT_SND_DEVICE_FREE);
                                     ^
hardware/qcom-caf/msm8996/audio/hal/audio_extn/utils.c:2530:2: error: invalid pr
eprocessing directive
#}
 ^
8 errors generated.
[ 57% 73999/128461] Building Kernel Image (Image.gz-dtb)



Code:
  DEPMOD  3.18.140-awesometic-kernel-v0.10+
make[1]: Verzeichnis „/home/michael/Compilieren/lineageos191/android/lineage/out
/target/product/gts3llte/obj/KERNEL_OBJ“ wird verlassen
make: Verzeichnis „/home/michael/Compilieren/lineageos191/android/lineage/kernel
/samsung/msm8996“ wird verlassen
depmod: WARNING: could not open modules.order at /home/michael/Compilieren/linea
geos191/android/lineage/out/target/product/gts3llte/obj/PACKAGING/depmod_vendor_
intermediates/lib/modules/0.0: No such file or directory
depmod: WARNING: could not open modules.builtin at /home/michael/Compilieren/lin
eageos191/android/lineage/out/target/product/gts3llte/obj/PACKAGING/depmod_vendo
r_intermediates/lib/modules/0.0: No such file or directory
16:37:10 ninja failed with: exit status 1

#### failed to build some targets (15:35 (mm:ss)) ####

Hello @Awesometic and @masdaster

This is the error message
 

retiredtab

Senior Member
Nov 16, 2017
1,239
813
Code:
hardware/qcom-caf/msm8996/audio/hal/audio_extn/utils.c:2523:2: error: invalid pr
eprocessing directive
#void audio_extn_utils_release_snd_device(snd_device_t snd_device)
 ^
hardware/qcom-caf/msm8996/audio/hal/audio_extn/utils.c:2524:2: error: invalid pr
eprocessing directive
If you are trying to comment out that code, it's not# for .c files.

It's
C:
/*

* all this stuff 
* in
* between 
* is commented
* out 

*/
 

boedster

New member
Sep 7, 2022
2
0
Can't install the rom. Get a Error 21 and now the tables is in a bootloop! How to recover the bootloop so I can retry to install the rom.
 
Can't install the rom. Get a Error 21 and now the tables is in a bootloop! How to recover the bootloop so I can retry to install the rom.
So you flashed just the ROM as you wrote and that gives you a bootloop?
When it reboots tried button combos to get into TWRP or Download Mode.
Which TWRP?
Did you "Format Data"?
 

Top Liked Posts

  • There are no posts matching your filters.
  • 1
    I have an SM-T820. Installed twrp-3.6.0_9-0 and flashed this rom. Magisk 25.2 (25200) app is installed but it's not rooted yet. Ramdisk shows Yes. Only option I have is to "select and patch a file". I tried extracting the boot.img from this ROM, patching it, then flashing in TWRP but that broke the kernal and resulted in a bootloop. ADB won't recognize the device in download mode. I've reflashed TWRP in Odin, then reflashed this ROM in TWRP, and it boots normal again.

    Can someone please explain how to get root with Magisk or point me to a guide that works?
    Install Magisk using TWRP. Just rename magisk.apk to magisk.zip. After reboot, the magisk will update to latest version and there will be an option to activate root. No need to use "select and patch a file."
  • 21
    Code:
    /*
    * Your warranty will be VOID after installing a custom ROM.
    *
    * Get notified yourself that I am not responsible for bricked devices, dead SD cards,
    * thermonuclear war, or you getting fired because the alarm app failed.
    * Please do some research if you have any concerns about features included in this ROM
    * before flashing it!
    * YOU are choosing to make these modifications,
    * and if you point the finger at me for messing up your device,
    * I will laugh at you.
    */


    # LineageOS

    LineageOS is a free, community built, aftermarket firmware distribution of Android 11, which is designed to increase performance and reliability over stock Android for your device.

    LineageOS is based on the Android Open Source Project with extra contributions from many people within the Android community. It can be used without any need to have any Google application installed. Linked below is a package that has come from another Android project that restore the Google parts. LineageOS does still include various hardware-specific code, which is also slowly being open-sourced anyway.

    All the source code for LineageOS is available in the LineageOS Github repo. And if you would like to contribute to LineageOS, please visit out Gerrit Code Review. You can also view the Changelog for a full list of changes & features.


    # What's working
    • Display/Touchscreen
      • LiveDisplay
    • Audio playback
      • Dolby Atmos
      • Headphone/Headset
      • Quad speakers
    • Video playback
      • HDR
    • Camera
    • Microphone
    • Sensors
    • Fingerprint sensor
    • GPS
    • LTE (SM-T825)
    • Hotspot
    • WiFi
    • WiFi display
    • Bluetooth
    • DRM
      • Widevine L1
    • USB ADB/MTP
    • Samsung Doze
    • S-Pen
      • Palm rejection
    • Hardware Encryption
      • MDFPP
    • SD Card
    • Power-off mode charging
    # Untested
    • FBE for userdata
    # What's not working
    • USB OTG
    • SELinux permissive
    • Please see the "Known issues" part of this post

    # Downloads

    ## LineageOS 19.1

    ## Google Apps
    • NikGapps
    • The other Gapps will work too, but I only confirmed that NikGapps working

    ## TWRP Recovery

    # How to install
    1. Unlock the bootloader.
    2. Download TWRP and flash the recovery image via Odin.
    3. Download LineageOS 19.1 for Galaxy Tab S3.
      • Be aware of the board name.
    4. Download GAPPS for Android 12L and the others you want to flash.
    5. Enter TWRP recovery.
      • The first boot to TWRP might be very slow because of the unmatched file systems.
    6. Format the whole system, data, cache partitions using the format menu.
      • You will type `yes` to do that.
    7. Flash the images.
      • If you're going to install GApps or something, you have to install the LineageOS first.
    8. Reboot the system.
    9. Done.

    # Known issues
    • Camera somewhat buggy
      • The built-in camera application (Camera2) is not working well. You can use another camera application like OpenCamera.
      • Sometimes the camera doesn't work after booting. You can fix that back by just rebooting.
      • After using the camera application, the Torch tile on the quick settings not working. But you can use the camera anyway.
      • On webcam chat apps, there is a vertical green bar and the color is not properly displayed.
    • Audio bugs
      • No sound for the microphone and speaker in voice calls, such as the regular phone call or voice chat with a meeting app.
    • Thank all of you for the feedback

    # Sources

    # Telegram Groups
    • If you are interested in developing this potential machine, please tell me through PM then I will send you the invitation link.
    • If you need a general discussion channel for this potential machine or want to share the news of its Android projects from anyone to everyone, you can join our discussion group chat.

    # Buy me a coffee

    # Credits / Special thanks to
    • Android Open Source Project
    • LineageOS Team
    • LOS17.1) @Valera1978 for his amazing previous work including his MSM8996 kernel
    • LOS18.1) @supermike86 and @samsuffit for testing LineageOS 18.1 for T820, which is I don't have one
    • LOS18.1) @bmwdroid and @cherepanov for confirming the LTE works
    • LOS18.1) @sebmue for letting me know that the useful information for palm rejection, and @ghostwheel for sharing its working source codes on Android 9
    • General) @switchgott for helping me in the development discussion and creating Telegram groups
    • General) All from our Telegram discussion channel, @EonOfBlack , Sands, David Becker, ...
    • LOS18.1) @LuK1337 for giving me a hint to fix the quad-speakers
    • LOS19.1) @followmsi , @html6405 , @ThE_MarD for giving me a hint to bring up Android 12
    • LOS19.1) @masdaster for the fix of MDFPP Keystore on our device
    10
    Hello all,

    After numerous tries, I could fix the camera and the Bluetooth/Headphone jack audio working.

    The camera is back, but still has some bugs, unfortunately.
    First, we can't use the default camera app, Camera2. It takes a shot but the result is cracked. But we can use a third party app like OpenCamera.
    And, there is something weird on the Torch. After using the camera with the flashlight, sometimes the Torch tile on the quick settings is broken, it just said "camera in use". But we still can use the camera.
    Lastly, sometimes the camera doesn't work at all after rebooting. Fortunately, it is easily fixed by rebooting again. I don't know why it is well.

    Now our audio HAL is built from the source. Previously, we were using audio HAL version 4.0 which is for Android 9 but now we're using version 6.0 which is for Android 11. I can move on to version 7.0, yeah, which is for Android 12, but from this version the configurations have to be modified in many ways so I just pended it.
    I had to supplement some audio configurations because of the compatibility of each version, maybe some audio scenarios were broken compared to our LineageOS 18.1. But I confirmed for most used scenarios like the quad-speaker, Bluetooth audio, headphone jack, and wireless display audio, so in most cases it will work well.

    I think, we can deprecate our LineageOS 18.1 now because our LOS 19.1 has no fewer features than LOS 18.1. :)
    9
    ## Changelogs
    • 2022. 9. 23
      • Synced with the latest LineageOS 19.1 repositories
        • Security patch by September 5, 2022

    • 2022. 8. 15
      • Synced with the latest LineageOS 19.1 repositories
        • android-12.1.0_r22
        • Security patch by August 5, 2022
      • About Keystore, switch to use MDFPP skeymast files again.
        • This will break your lock screen. Please remove `/data/system/locksettings.db` file using TWRP, then lock screen will be fixed and your biometric information will be removed. Please reset your biometric lock method again. Sorry for the inconvenience.
        • Thank you for the idea and contribution for the proper use of our MDFPP Keystore, @masdaster :)
    • 2022. 7. 15
      • Synced with the latest LineageOS 19.1 repositories
        • android-12.1.0_r11
        • Security patch by July 5, 2022
      • Added support for Sony DualShock 4 gamepad
      • Increased headphone jack volume by about 20%
      • Updated USB HAL to v1.3
    • 2022. 6. 11
    • 2022. 4. 16
      • Synced with the latest LineageOS 19.1 repositories
        • android-12.1.0_r4
      • Fixed the boot failure issue for some users
        • It is related to the Keystore of the Android system, I did a little compromise to make it work for all users
        • If you are using the first version (220320), you have to clean install to this version or you may fail to unlock the screen , you have to boot into TWRP and remove the file `locksettings.db` under `/data/system` directory. This will resolve the unlock failure issue after dirty-flashing it.
          • Thanks for this information, David Becker. :)
    • 2022. 3. 20
      • Initial release
    8
    ## Special Notes
    • You must do clean-install if you are willing to upgrade from another ROM such as an Android 11 based one
    • I have tested Magisk 24.3 working
      • You can fix SafetyNet using Magisk modules, SafetyNet Fix and PropsConfig
    • You can hide the soft nav buttons on the bottom bar. This is the workaround.
      • 1. Go to "System -> Buttons" and check "Enable on-screen nav bar" to enable soft nav bar temporarily
      • 2. Go to "System -> Gestures" and set "System navigation" to "Gesture navigation"
      • 3. Go back to "System -> Buttons" and check "Enable on-screen nav bar" again to disable soft nav bar and enable hardware key.
    • You can hide the bottom Taskbar. This is the workaround.
      • 1. Go to "System -> Buttons" and check "Enable on-screen nav bar" to enable soft nav bar temporarily
      • 2. Go back using navigation bar and go to the "Buttons" menu again
      • 3. Then we can see the "Enable taskbar" option that we couldn't see before. Disable that option.
      • 4. And disable "Enable on-screen nav bar" option again to use the hardware buttons back.
    8
    Finally I think I found which thing I should look into to fix the camera and the remaining audio things including Bluetooth audio, headphone jack and the audio when screen recording.

    Currently I managed to fix the camera working, which comes with some bugs yet but we can use it.
    But I couldn't fix the audio yet. I found the root cause but don't know how to fix that.

    So, the new one will come and I think it is not so far. If I can't fix the audio for a few days, then I will upload the new release including the working camera. :)