[ROM][UNOFFICIAL][instantnoodle][10] LineageOS 17.1

[AndyYan]

Thanks @LuK1337 for the original work on OP8Pro and thanks OP for the adaptation. Built it on my side and running nicely, aside from the obvious vibrator issue which happens on GSIs as well. I'll make an updated build for you guys in a bit.
Speaking of GSIs, they don't run well on this device (or maybe I'm missing a fix somewhere), and for my main device I wanted something more reliable, so here I am. Haven't ran device-specific ROMs in a long while...

EDIT: Here - 90Hz by default (lock and unlock screen on each boot), and tweaked cutout/dimensions to my liking. No guarantees.

 

[shaneg79]

Thanks @LuK1337 for the original work on OP8Pro and thanks OP for the adaptation. Built it on my side and running nicely, aside from the obvious vibrator issue which happens on GSIs as well. I'll make an updated build for you guys in a bit.
Speaking of GSIs, they don't run well on this device (or maybe I'm missing a fix somewhere), and for my main device I wanted something more reliable, so here I am. Haven't ran device-specific ROMs in a long while...

EDIT: Here - 90Hz by default (lock and unlock screen on each boot), and tweaked cutout/dimensions to my liking. No guarantees.

Will it allow gapps to be installed? Or does it still give the not enough space error?

 

[passion8059]

Thanks @LuK1337 for the original work on OP8Pro and thanks OP for the adaptation. Built it on my side and running nicely, aside from the obvious vibrator issue which happens on GSIs as well. I'll make an updated build for you guys in a bit.
Speaking of GSIs, they don't run well on this device (or maybe I'm missing a fix somewhere), and for my main device I wanted something more reliable, so here I am. Haven't ran device-specific ROMs in a long while...

EDIT: Here - 90Hz by default (lock and unlock screen on each boot), and tweaked cutout/dimensions to my liking. No guarantees.

Andy,

Thanks for this build!

Installed via fastboot and then flashed twrp, installed Pico gapps. Works perfect. Amazing stuff! ???

 

[KennyG9]

Sorry guys, I'm not very active on this thread because I've been quite busy lately . There's lot of stuff to work on (most importantly play services, borked vibrator and update proprietary blobs and the lineage release), but I just can't find enough spare time… Not sure when I'll be able to get back to it without help.

Thanks @LuK1337 for the original work on OP8Pro and thanks OP for the adaptation. Built it on my side and running nicely, aside from the obvious vibrator issue which happens on GSIs as well. I'll make an updated build for you guys in a bit.
Speaking of GSIs, they don't run well on this device (or maybe I'm missing a fix somewhere), and for my main device I wanted something more reliable, so here I am. Haven't ran device-specific ROMs in a long while...

EDIT: Here - 90Hz by default (lock and unlock screen on each boot), and tweaked cutout/dimensions to my liking. No guarantees.

Can you publish sources for this or submit a patch upstream?

 

[AndyYan]

Can you publish sources for this or submit a patch upstream?

Sure, based on yours, it's on GitHub though: https://github.com/AndyCGYan/android_device_oneplus_instantnoodle

 

[KennyG9]

Sure, based on yours, it's on GitHub though: https://github.com/AndyCGYan/android_device_oneplus_instantnoodle

Thanks for this contribution. I just merged your commits into my tree and released a new build. You seem to have a lot more knowledge and experience than me on building LOS, so in the meantime, if you find out I'm doing something wrong or I'm not doing something I should do, please do let me know. I'll try to improve.

 

[SUPERUSER]

Thanks for this contribution. I just merged your commits into my tree and released a new build. You seem to have a lot more knowledge and experience than me on building LOS, so in the meantime, if you find out I'm doing something wrong or I'm not doing something I should do, please do let me know. I'll try to improve.

Any news on FOD using magisk?

 

[KennyG9]

Any news on FOD using magisk?

FOD and Magisk are both working great on my OP8 with this ROM. But it was already working for me with the initial release I made in July.

 

[SUPERUSER]

FOD and Magisk are both working great on my OP8 with this ROM. But it was already working for me with the initial release I made in July.

May I ask for specific install instruction/or step by step how you flashed the rom?


I tried it now and fingerprint is no where to be found in settings app after flashing magisk.
I did the same procedure as on stock rom, take the extracted img file from the payload, transfer the file and patch it with magisk and then flash the kernel in fastboot.
Maybe this is not required on custom roms, maybe I could flash it right away?
I just hope I might get this to work

 

[KennyG9]

May I ask for specific install instruction/or step by step how you flashed the rom?


I tried it now and fingerprint is no where to be found in settings app after flashing magisk.
I did the same procedure as on stock rom, take the extracted img file from the payload, transfer the file and patch it with magisk and then flash the kernel in fastboot.
Maybe this is not required on custom roms, maybe I could flash it right away?
I just hope I might get this to work

Mmh weird ?. I don't do anything fancy and always had FOD and Magisk working: I just pull the original ROM's zip and Magisk's zip to my sdcard (as sideloading don't work in @mauronofrio 's TWRP yet), then I flash the ROM using TWRP, reboot to TWRP, then flash Magisk. Then I can boot and configure my fingerprints normally, under "Security => Fingerprint" or following the onboarding instructions if it's a first boot. Not sure why your procedure would produce a different result though, but man this FOD's software is so fragile I'm not even surprised…

Maybe worth noting: while working on making this ROM, I bricked the fingerprint sensor twice for unclear reasons. Trying to register a new fingerprint would result in a “Enrollment was not complete” popup and factory resetting (normally or with MsmDownloadTool) wouldn't change anything. I was still able to fix the FOD by following this annoying but god sent procedure. That is to say: if you start tweaking, I strongly advise that you backup your "persist" partition as indicated at beginning of the procedure I linked. This may just prevent you a lot of hassle later.

 

[SUPERUSER]

Mmh weird ?. I don't do anything fancy and always had FOD and Magisk working: I just pull the original ROM's zip and Magisk's zip to my sdcard (as sideloading don't work in @mauronofrio 's TWRP yet), then I flash the ROM using TWRP, reboot to TWRP, then flash Magisk. Then I can boot and configure my fingerprints normally, under "Security => Fingerprint" or following the onboarding instructions if it's a first boot. Not sure why your procedure would produce a different result though, but man this FOD's software is so fragile I'm not even surprised…

Maybe worth noting: while working on making this ROM, I bricked the fingerprint sensor twice for unclear reasons. Trying to register a new fingerprint would result in a “Enrollment was not complete” popup and factory resetting (normally or with MsmDownloadTool) wouldn't change anything. I was still able to fix the FOD by following this annoying but god sent procedure. That is to say: if you start tweaking, I strongly advise that you backup your "persist" partition as indicated at beginning of the procedure I linked. This may just prevent you a lot of hassle later.

Okay, it is exactly what I did.
Thank you for reminding to backup persist.img, I did this the first time I rooted the phone, so I got that covered.
I fiddled around last night and this morning and discovered some patterns.
I was on Android 11 open beta 3 before and could not get anything custom booted.
I ended up at qualcom crash mode with trying to kill init 0x000f00 something.
After I flashed the phone in edl mode with msm tool Android 11 image to recover to stock rom I could not get anything booted either.
But after downloading the Android 10 image and running the msm tool I could get a recovery booting and also flash a rom.
First I flashed rom and magisk in one go like you mentioned but no fingerprint enrollment.
Now I tried one more time without magisk and fingerprint is not detected at first time boot or in settings and just to be sure I tested both this LineageOS and the PixelExperience_Plus_instantnoodle-10.0-20201117-1130-OFFICIAL.
Neither rom has fingerprint visible at all, magisk or no magisk.
I have been off the android dev for some years now, I don't have all knowledge about the way android is handled nowadays.
But something must have happened/changed during firmware upgrade.
I know that I had fingerprint working on a clean flash right after I bought the phone, but now nothing.

I attached all logs in a zip, hopefully it will be to some help.
I installed magisk just so I could have root to dump all logs.


It wasn't all for waste, I didn't the Android 11 update, I got almost no notifications and some apps crashes so I wanted to downgrade for some time to let 11 mature some.
Plus mods are not working on 11 so Dolby is permanent on making the lowest volume level being very loud.

 

[ioctl0]

Is there any guide to build this unofficial firmware from these sources: https://gitlab.com/nlr/android_device_oneplus_instantnoodle , https://github.com/luk1337/android_device_oneplus_sm8250-common , https://github.com/luk1337/android_kernel_oneplus_sm8250 .

If no, what should be changed in this guide to build firmware for Oneplus 8?

 

[bruelltaube]

Coming from LuK1337's build for the 8pro, I just flashed your build...

FOD, 90 hertz refresh rate, november security update, active screen size - all working just perfectly

THX alot @KennyG9 and AndyYan - your work is truly apreciated!

 

[KennyG9]

Is there any guide to build this unofficial firmware from these sources: https://gitlab.com/nlr/android_device_oneplus_instantnoodle , https://github.com/luk1337/android_device_oneplus_sm8250-common , https://github.com/luk1337/android_kernel_oneplus_sm8250 .

If no, what should be changed in this guide to build firmware for Oneplus 8?

You need to add this to your ".repo/local_manifest.xml" so that the build scripts can find all projects:

<?xml version="1.0" encoding="UTF-8"?>
<manifest>
  <remote name="gitlab_nlr" fetch="https://gitlab.com/nlr" />
  <project name="android_device_oneplus_instantnoodle" path="device/oneplus/instantnoodle" remote="gitlab_nlr" revision="lineage-17.1" />
  <project name="luk1337/proprietary_vendor_oneplus" path="vendor/oneplus" remote="github" revision="lineage-17.1" />
  <project name="luk1337/android_device_oneplus_sm8250-common" path="device/oneplus/sm8250-common" remote="github" revision="lineage-17.1" />
  <project name="luk1337/android_kernel_oneplus_sm8250.git" path="kernel/oneplus/sm8250" remote="github" revision="lineage-17.1" />
  <project name="LineageOS/android_device_oneplus_common" path="device/oneplus/common" remote="github" revision="lineage-17.1" />
</manifest>

Then "repo sync", "breakfast instantnoodle" and "brunch instantnoodle" should suffice.

 

[KennyG9]

Coming from LuK1337's build for the 8pro, I just flashed your build...

FOD, 90 hertz refresh rate, november security update, active screen size - all working just perfectly

THX alot @KennyG9 and AndyYan - your work is truly apreciated!

Glad it works for you. I'll try to make releases more often even if I don't work on the tree as I just have one command to run to release the whole thing.

 

[ioctl0]

> Then "repo sync", "breakfast instantnoodle" and "brunch instantnoodle" should suffice.

Thank's, it help!

I have noticed, that the Linux kernel uses "cfq" instead of "noop" IO scheduler by default. Switching to "noop" increases IO performance a little bit (following AndroBench app), and also should decrease responsibility time.
You can temporary switch IO scheduler for tests with programs like Kernel Adiutor, or directly with ADB.

And also "performance" CPU scaling governor is configured by default instead of "schedutil" in kernel. It seems the governor switched to "schedutil" during the boot, but it can be turned on directly in kernel to avoid usage of suboptimal default "performance".

 

[KennyG9]

Okay, it is exactly what I did.
Thank you for reminding to backup persist.img, I did this the first time I rooted the phone, so I got that covered.
I fiddled around last night and this morning and discovered some patterns.
I was on Android 11 open beta 3 before and could not get anything custom booted.
I ended up at qualcom crash mode with trying to kill init 0x000f00 something.
After I flashed the phone in edl mode with msm tool Android 11 image to recover to stock rom I could not get anything booted either.
But after downloading the Android 10 image and running the msm tool I could get a recovery booting and also flash a rom.
First I flashed rom and magisk in one go like you mentioned but no fingerprint enrollment.
Now I tried one more time without magisk and fingerprint is not detected at first time boot or in settings and just to be sure I tested both this LineageOS and the PixelExperience_Plus_instantnoodle-10.0-20201117-1130-OFFICIAL.
Neither rom has fingerprint visible at all, magisk or no magisk.
I have been off the android dev for some years now, I don't have all knowledge about the way android is handled nowadays.
But something must have happened/changed during firmware upgrade.
I know that I had fingerprint working on a clean flash right after I bought the phone, but now nothing.

I attached all logs in a zip, hopefully it will be to some help.
I installed magisk just so I could have root to dump all logs.


It wasn't all for waste, I didn't the Android 11 update, I got almost no notifications and some apps crashes so I wanted to downgrade for some time to let 11 mature some.
Plus mods are not working on 11 so Dolby is permanent on making the lowest volume level being very loud.

If you flashed OOS 11, maybe you can you try this build of LOS 18.0 I just made: https://drive.google.com/file/d/1Wy0pI6dFBKC5W3YPeQPiW5NaJtNp1WEX . You must flash it through fastboot instead of TWRP though:

$ adb reboot bootloader
$ fastboot -w (this will wipe your data)
$ fastboot flash recovery recovery.img
$ fastboot reboot fastboot
$ fastboot erase scratch
$ fastboot flash boot boot.img
$ fastboot flash dtbo dtbo.img
$ fastboot flash system system.img
$ fastboot flash system_ext system_ext.img
$ fastboot flash product product.img
$ fastboot flash vbmeta vbmeta.img
$ fastboot flash vbmeta_system vbmeta_system.img
$ fastboot reboot

(instructions from https://forum.xda-developers.com/oneplus-8-pro/development/rom-lineageos-18-0-t4192827)

Let me know if it works for you. I haven't been able to test it yet but wanted to share it with you before.

 

[Abhay Singh Gill]

> Then "repo sync", "breakfast instantnoodle" and "brunch instantnoodle" should suffice.

Thank's, it help!

I have noticed, that the Linux kernel uses "cfq" instead of "noop" IO scheduler by default. Switching to "noop" increases IO performance a little bit (following AndroBench app), and also should decrease responsibility time.
You can temporary switch IO scheduler for tests with programs like Kernel Adiutor, or directly with ADB.

And also "performance" CPU scaling governor is configured by default instead of "schedutil" in kernel. It seems the governor switched to "schedutil" during the boot, but it can be turned on directly in kernel to avoid usage of suboptimal default "performance".

Ur creating a custom ROM or a custom kernel?

 

[ioctl0]

Ur creating a custom ROM or a custom kernel?

I just built firmware from sources.

 

[passion8059]

Tried Lineage 18, would not boot sent straight back to fastboot (bootloader). Even after installing OOS11 and clean flashing that way same result.