I'll chime in on Pros/Cons for flashing a stock AT&T S8+ to the Unlocked firmware
Pros:
No Carrier Bloat
Caller ID
Spam Protection
Better Battery Life
More System Storage Space
Cons:
No VoLTE
No Wifi Calling
No Video Calling
No Visual Voicemail built into the dialer app (but if you get the at&t visual voicemail app, it works just fine)
My take:
I switched to unlocked firmware last week and I'm happy so far. I don't really care about volte or wifi calling, maybe your situation is different. I get a lot of robo calls (like 3+ a day) so the caller id and spam protection is a godsend. Also I hate at&t and seeing their logo when i boot my phone and all of their stupid buggy garbage apps i can't get rid of in my app drawer slightly raises my blood pressure every single time i look at them.
Other things to consider
-typically at&t takes extremely long (in relation to other carriers/unlocked) to push out updates, too early to tell how that will play out though
-flashing is not permanent and does not void your warranty, the only negative is that you have to wipe your phone and re set it up and customize things the way you like it