TWRP 2.8.7.0 for i777/S959G [MTP] [ENCRYPTION]

[cyril279]

I've brought this here to keep this discussion in a more relevant thread.

Interesting ... I couldn't get PRODUCT_COPY_FILES to work on twrp.fstab. I wonder what I was doing wrong. I had to mess with the build/core/Makefile ;(

Using Slim's build source;
When I build the whole rom, that product_copy_files works as expected on the twrp.fstab.

When I "make -j# bootzip" I have to manually copy the twrp.fstab to the /out/recovery/boot/etc. I usually build the whole rom, so it hasn't been much of an issue, but it sounds like you made a change that allowed it to copy as expected?

 

[dimoochka]

I've brought this here to keep this discussion in a more relevant thread.



Using Slim's build source;
When I build the whole rom, that product_copy_files works as expected on the twrp.fstab.

When I "make -j# bootzip" I have to manually copy the twrp.fstab to the /out/recovery/boot/etc. I usually build the whole rom, so it hasn't been much of an issue, but it sounds like you made a change that allowed it to copy as expected?

Yes, and it only took me 4 hours of grepping through the labyrinth of the build system! That makes sense - I guess PRODUCT_COPY_FILES doesn't work when you're just doing a partial build - I was using mka bootimage and had to manually copy the twrp.fstab every time, which was turning into a pain. 0001-twrp-setup.patch has the proper adjustments (including turning adb.secure off for recovery).

 

[dimoochka]

I've brought this here to keep this discussion in a more relevant thread.



Using Slim's build source;
When I build the whole rom, that product_copy_files works as expected on the twrp.fstab.

When I "make -j# bootzip" I have to manually copy the twrp.fstab to the /out/recovery/boot/etc. I usually build the whole rom, so it hasn't been much of an issue, but it sounds like you made a change that allowed it to copy as expected?

Aside from the basics (twrp.fstab, BoardConfig.mk, replacing bootable/recovery repo with omnirom/android_bootable_recovery), did you have to do anything special to get this working? For whatever reason my fully built ota .zip only installs a handful of files into /system when bootable/recovery is non-stock...

 

[cyril279]

Aside from the basics (twrp.fstab, BoardConfig.mk, replacing bootable/recovery repo with omnirom/android_bootable_recovery), did you have to do anything special to get this working? For whatever reason my fully built ota .zip only installs a handful of files into /system when bootable/recovery is non-stock...

As long recovery boots and works as expected, I have never paid attention to what the quantity or location of files being moved by the process.

To answer the initial question, because I was working with a non-omni rom, I did also need to make sure that a specific external_sepolicy commit was present, or the device would not boot properly into recovery, although [ adb devices ] recognized that the device was in recovery mode.

In looking for it, I also spotted another non-Omni-specific recovery commit aimed at CM, but I have not been using it for my builds.

-Cyril