Yes, sorry. I deleted it just after it was posted. I wanted to write in a Galaxy S9 thread but accidently put it here.wat?
the device trees in the gitlab orgs are pretty much to lineage rules (that was the point on the recreating on gitlab in the first place)
why wasting time in redoing it when we have perfectly fine trees already
putting local hal clones into hardware/samsung is a bad idea (and probably wont get merged into lineage) the standard is to just copy them into the device trees
I tried to explain the thing that one maintainer did is cloning all HALs from LineageOS that the device needs into the device tree without any important modification. He could just directly build it from LineageOS/android_hardware_samsung instead of doing that.