where to begin to port to a newer Lineage Release?

retiredtab · Dec 25, 2020 at 11:24 PM

retiredtab said:
but the result is an image that won't boot. The recovery image won't boot meaning something's wrong with the boot/kernel stage.

This kernel config parameter change was required to let kernel boot.

https://review.exynos5420.com/c/exynos5420/android_kernel_samsung_exynos5420/+/7479

CONFIG_SECURITY_SELINUX_DEVELOP=y

I have never heard or seen this parameter and I would have never figured it out.

After it booted, then it got stuck at the boot animation and needed this patch (I knew this from adb logcat while it was booting)

https://review.exynos5420.com/c/exynos5420/android_device_samsung_klimtwifi/+/7310

Code:

 12-25 16:59:24.616  E  [2636/2636] System   ******************************************
 12-25 16:59:24.617  E  [2636/2636] System   ************ Failure starting system services
 12-25 16:59:24.617  E  [2636/2636] System   java.lang.IllegalStateException: Signature|privileged permissions not in privapp-permissions whitelist: {com.validity.fingerprint: android.permission.INTERACT_ACROSS_USERS}                                                                                                 

 12-25 16:59:24.618  D  [2636/2636] AndroidRuntime Shutting down VM
 12-25 16:59:24.619  E  [2636/2636] AndroidRuntime *** FATAL EXCEPTION IN SYSTEM PROCESS: main
 12-25 16:59:24.619  E  [2636/2636] AndroidRuntime java.lang.IllegalStateException: Signature|privileged permissions not in privapp-permissions whitelist: {com.validity.fingerprint: android.permission.INTERACT_ACROSS_USERS}

retiredtab · Dec 25, 2020 at 11:35 PM

Home button to wake tablet fixed. I learned this from the SM-T350 when I first started down this path.

Galaxy-MSM8916/android_device_samsung_gt58wifi

Contribute to Galaxy-MSM8916/android_device_samsung_gt58wifi development by creating an account on GitHub.

github.com

Code:

12-25 16:29:01.058  I  [2638/2723] PowerManagerService Waking up from sleep (uid=1000 reason=android.policy:KEY)...

bluess57 · Dec 31, 2019 14 1 3

retiredtab said:
Home button to wake tablet fixed. I learned this from the SM-T350 when I first started down this path.

Galaxy-MSM8916/android_device_samsung_gt58wifi

Contribute to Galaxy-MSM8916/android_device_samsung_gt58wifi development by creating an account on GitHub.

github.com

Code:

12-25 16:29:01.058 I [2638/2723] PowerManagerService Waking up from sleep (uid=1000 reason=android.policy:KEY)...

yeah there is an overlay file setting for home button to wake , obviously not applied to gerrit changes as yet

bluess57 · Dec 31, 2019 14 1 3

retiredtab said:
This kernel config parameter change was required to let kernel boot.

https://review.exynos5420.com/c/exynos5420/android_kernel_samsung_exynos5420/+/7479

CONFIG_SECURITY_SELINUX_DEVELOP=y

I have never heard or seen this parameter and I would have never figured it out.

After it booted, then it got stuck at the boot animation and needed this patch (I knew this from adb logcat while it was booting)

https://review.exynos5420.com/c/exynos5420/android_device_samsung_klimtwifi/+/7310

Code:

12-25 16:59:24.616 E [2636/2636] System ****************************************** 12-25 16:59:24.617 E [2636/2636] System ************ Failure starting system services 12-25 16:59:24.617 E [2636/2636] System java.lang.IllegalStateException: Signature|privileged permissions not in privapp-permissions whitelist: {com.validity.fingerprint: android.permission.INTERACT_ACROSS_USERS} 12-25 16:59:24.618 D [2636/2636] AndroidRuntime Shutting down VM 12-25 16:59:24.619 E [2636/2636] AndroidRuntime *** FATAL EXCEPTION IN SYSTEM PROCESS: main 12-25 16:59:24.619 E [2636/2636] AndroidRuntime java.lang.IllegalStateException: Signature|privileged permissions not in privapp-permissions whitelist: {com.validity.fingerprint: android.permission.INTERACT_ACROSS_USERS}

The kernel config command line set selinux to permissive (whilst under development)
see this inside your devices _defconfig file:-
CONFIG_CMDLINE="console=ttySAC2,115200n8 vmalloc=512M androidboot.console=ttySAC2 androidboot.selinux=permissive"

yeah finger print is not functional atm

alexenferman · Dec 26, 2020 at 12:22 AM

bluess57 said:
by does not boot, do you mean it is stuck at the lineageos 3 rings startup animation?

Bootlogo is showing, then initlogo is displayed (part of the kernel) and it shuts off. I checked the logs and it appears that some files from vendor are missing.

bluess57 · Dec 31, 2019 14 1 3

alexenferman said:
Bootlogo is showing, then initlogo is displayed (part of the kernel) and it shuts off. I checked the logs and it appears that some files from vendor are missing.

Post some log details

alexenferman · Dec 26, 2020 at 3:15 AM

There: https://del.dog/imununomer.txt
Thank you by the way for helping me

Device sources: https://github.com/Samsung-Galaxy-S3-MSM8960

bluess57 · Dec 31, 2019 14 1 3

alexenferman said:
There: https://del.dog/imununomer.txt
Thank you by the way for helping me

Device sources: https://github.com/Samsung-Galaxy-S3-MSM8960

I'm not familiar with your device/code , so not sure I can help much.
I'd start with booting with SELinux in permissive mode /disabled.

alexenferman · Dec 26, 2020 at 3:49 AM

bluess57 said:
I'm not familiar with your device/code , so not sure I can help much.
I'd start with booting with SELinux in permissive mode /disabled.

Thanks for the help!

retiredtab · Dec 27, 2020 at 7:18 PM

I have 16.0 klimtiwif SM-T700 booting now. With the same changes from SM-T800, it got stuck at the boot animation. I had to remove [email protected] so it would boot. I know the sensors code is still pending merge so I'm not too worried about this.

I'm just getting my hard drive ready for SM-T700 by pre-building. I have separate hard drives for each rom build to help me keep everything straight.

Code:

12-27 18:49:31.342  F  [18964/18964] DEBUG    *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
 12-27 18:49:31.343  F  [18964/18964] DEBUG    LineageOS Version: '16.0-20201227-UNOFFICIAL-klimtwifi'
 12-27 18:49:31.343  F  [18964/18964] DEBUG    Build fingerprint: 'samsung/klimtwifixx/klimtwifi:6.0.1/MMB29K/T700XXU1CRF1:user/release-keys'
 12-27 18:49:31.343  F  [18964/18964] DEBUG    Revision: '0'
 12-27 18:49:31.343  F  [18964/18964] DEBUG    ABI: 'arm'
 12-27 18:49:31.343  F  [18964/18964] DEBUG    pid: 18895, tid: 18949, name: system-server-i  >>> system_server <<<
 12-27 18:49:31.343  F  [18964/18964] DEBUG    signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
 12-27 18:49:31.343  F  [18964/18964] DEBUG    Abort message: 'Sensors.cpp:98] Check failed: getHalDeviceVersion() >= ((((1) & 0xff) << 24) | (((3) & 0xff) << 16) | ((1) & 0xffff)) (getHalDeviceVersion()=0, ((((1) & 0xff) << 24) | (((3) & 0xff) << 16) | ((1) & 0xffff))=16973825) '                                 
 12-27 18:49:31.343  F  [18964/18964] DEBUG        r0  00000000  r1  00004a05  r2  00000006  r3  00000008
 12-27 18:49:31.343  F  [18964/18964] DEBUG        r4  000049cf  r5  00004a05  r6  98cf2df4  r7  0000010c
 12-27 18:49:31.343  F  [18964/18964] DEBUG        r8  00000002  r9  b219c700  r10 990b82dd  r11 b202b87e
 12-27 18:49:31.343  F  [18964/18964] DEBUG        ip  00000041  sp  98cf2de0  lr  b24eb0f5  pc  b24e2e1a
 12-27 18:49:31.364  F  [18964/18964] DEBUG   
 12-27 18:49:31.364  F  [18964/18964] DEBUG    backtrace:
 12-27 18:49:31.364  F  [18964/18964] DEBUG        #00 pc 0001ce1a  /system/lib/libc.so (abort+58)
 12-27 18:49:31.364  F  [18964/18964] DEBUG        #01 pc 0035a9a3  /system/lib/libart.so (art::Runtime::Abort(char const*)+950)
 12-27 18:49:31.364  F  [18964/18964] DEBUG        #02 pc 000071c3  /system/lib/libbase.so (android::base::LogMessage::~LogMessage()+506)
 12-27 18:49:31.364  F  [18964/18964] DEBUG        #03 pc 000056b9  /system/vendor/lib/hw/[email protected] (android::hardware::sensors::V1_0::implementation::Sensors::Sensors()+668)                                                                                                                 
 12-27 18:49:31.364  F  [18964/18964] DEBUG        #04 pc 00006391  /system/vendor/lib/hw/[email protected] (HIDL_FETCH_ISensors+8)

garak elim · Dec 31, 2020 at 4:22 PM

Happy new year

retiredtab · Dec 31, 2020 at 6:06 PM

@garak elim, did you merge the pending changes or just compiled, like I, without them.

garak elim · Dec 31, 2020 at 7:03 PM

When you stuck at the boot animation you have to run "development/tools/privapp_permissions/privapp_permissions.py" and copy this permision from console to new file (privapp-permissions-fingerprint.xml) in your device tree in /config folder (in mine case). After this write this line to device.mk file.

PRODUCT_COPY_FILES += \
$(LOCAL_PATH)/configs/privapp-permissions-fingerprint.xml:/system/etc/permissions/privapp-permissions-fingerprint.xml

More info here https://source.android.com/devices/tech/config/perms-allowlist

garak elim · Dec 31, 2020 at 7:09 PM

Also I merge some changes from lineage-15.1 chagallwifi branch and some from chagalllte lineage-16.0 branch
For example this was needed for compilation.

https://review.exynos5420.com/c/exynos5420/android_device_samsung_chagallwifi/+/3593

retiredtab · Dec 31, 2020 at 7:17 PM

@garak elim, yes, I ran into both of those problems and more, but perhaps I should have been more clear about my question. I plan to submit gerrit changes once everything works. Right now, I have a working 16.0 build of T700 and T800.

I'm asking if you merged the pending 16.0 changes like you see at

https://review.exynos5420.com/q/status:open

For example, topic p-multihal needs to be merged into 16.0 so that we have hal + sensors.

garak elim · Dec 31, 2020 at 7:33 PM

retiredtab said:
@garak elim, yes, I ran into both of those problems and more, but perhaps I should have been more clear about my question. I plan to submit gerrit changes once everything works. Right now, I have a working 16.0 build of T700 and T800.

I'm asking if you merged the pending 16.0 changes like you see at

https://review.exynos5420.com/q/status:eek:pen

For example, topic p-multihal needs to be merged into 16.0 so that we have hal + sensors.

No, I have made changes only in chagallwifi device tree.

garak elim · Dec 31, 2020 at 7:42 PM

More info - my personal build of Lineage 16 for T800 is not good. Its very buggy. I try merged p-multihal changes to my sources.

retiredtab · Dec 31, 2020 at 8:04 PM

garak elim said:
More info - my personal build of Lineage 16 for T800 is not good. Its very buggy.

Can you explain what's buggy? So far, in my limited use of my build, I have run into no problems other than what I listed earlier due pending hal + sensor + camera merge changes.

garak elim · Dec 31, 2020 at 8:19 PM

After instaling micro-opengapps, magisk and few apps rom has started crashing every few minutes. I have to abandon my build and start make new one.
I try with those p-multihal, but I cannot merge with repopick Jan Altensen patches together with Thomas Patry patches without error. I have to do manually.

retiredtab · Dec 31, 2020 at 8:46 PM

I'm running Aurora store (no gapps), no magisk, but I'm using smartcookie web browser and newpipe without problems. So far, no random crashes or reboots for me.

I also get merge conflicts when trying to merge the 16.0 pending changes, but am patiently waiting for the team to sort out hal + sensors + camera before I proceed any further.

where to begin to port to a newer Lineage Release?

Senior Member

Senior Member

Member

Member

Senior Member

Member

Senior Member

Member

Senior Member

Senior Member

Senior Member

Senior Member

Senior Member

Senior Member

Senior Member

Senior Member

Senior Member

Senior Member

Senior Member

Senior Member