The more storage the better I always say. I was a little disappointed that there was only the 512gb option. I had to go get a 1TB SD card to compensate. I store everything on the phone. And I mean everything. Movies, shows, music, photos, documents. I always use my phone as my main computer. I use my pc to play games. For absolutely everything else (plus more games) I use whatever my current Android phone is. And it's really hard to use anything other than Samsung phones lately for their performance and storage capacities.
Computer storage is much bigger and cheaper, than phone, also safer (much harder to loose your computer than phone), so my main storage and backups is all on computer hard drives, my phone has only current stuff on it, but easy to upload/remove. Not to mention file access, which I despise on Android, you could not pay me enough money to make me work with larger number of files on the phone, like sorting pictures by interest etc. it all goes to Windows computer, gets sorted out, then goes back to phone. Right now I use about 180GB of my phone memory for data (I have another 3TB saved on HD), but if I didn't maintain it, it would be full long time ago, my wife is like that no matter how big the phone, she'll run out of memory in 3-6 months.