FORUMS
Remove All Ads from XDA

[MOD][XPOSED] TimePicker Fix

247 posts
Thanks Meter: 82
 
Post Reply Email Thread
Requires Xposed framework!

Hey guys,

I was surprised to see that no one made this before, so here is a module that fixes the broken Android TimePicker.

I consider the TimePicker broken because changing the minute from 59 to 0, or vice versa, increments or decrements the hour, respectively. Since it's common to choose a time by first setting the hour and then the minute, this is really annoying.
This module removes the described behavior from time pickers implemented using the android.widget.TimePicker class.

APK and source for the first version are attached.

The module can also be found on the Xposed repo: net.feichti.timepickerfix

Edit:
To be clear, I'm talking about the old spinner-style time picker like the right one in this picture, not the pretty one on the left.
Click image for larger version

Name:	timepicker.png
Views:	1235
Size:	59.6 KB
ID:	2977340

Update v1.1:
I uploaded a new version which adds the fix for date pickers.
The Following 8 Users Say Thank You to Pezo For This Useful Post: [ View ] Gift Pezo Ad-Free
 
 
9th October 2014, 05:49 PM |#2  
terrorist96's Avatar
Senior Member
Thanks Meter: 97
 
More
I don't think this affects my Moto X. If I choose the minute, the hour doesn't change regardless of going past 59 out before 00. Is this a problem in xperia or stock Android only?
9th October 2014, 06:29 PM |#3  
OP Senior Member
Flag Linz
Thanks Meter: 82
 
Donate to Me
More
It's that way at least in AOSP (it's in the code) and on my Xperia Z1c.
I believe I've read something about it also, but I cannot remember where.
9th October 2014, 10:12 PM |#4  
chrisch91's Avatar
Senior Member
Thanks Meter: 30
 
More
It is also not working for me. Nexus 5
10th October 2014, 12:11 AM |#5  
OP Senior Member
Flag Linz
Thanks Meter: 82
 
Donate to Me
More
Are you running AOSP?
Could you look at the Xposed log if there's some error?
7th December 2014, 10:49 AM |#6  
Senior Member
/etc/
Thanks Meter: 35
 
More
Hi. Just started to use your great module. Been scratching my head since I started using my new phone (old one doesn't need fixing date/time) and didn't expected such weird behaviour from newer Android.

Would be great if the 'fix' being implemented for date also, since the 'feature/bug' not only affected time but date too.
8th December 2014, 09:08 AM |#7  
OP Senior Member
Flag Linz
Thanks Meter: 82
 
Donate to Me
More
Quote:
Originally Posted by kotey

Hi. Just started to use your great module. Been scratching my head since I started using my new phone (old one doesn't need fixing date/time) and didn't expected such weird behaviour from newer Android.

Would be great if the 'fix' being implemented for date also, since the 'feature/bug' not only affected time but date too.

I just uploaded a new version which adds this. Check it out and tell me if it's working for you.
The Following User Says Thank You to Pezo For This Useful Post: [ View ] Gift Pezo Ad-Free
9th December 2014, 05:55 PM |#8  
Senior Member
/etc/
Thanks Meter: 35
 
More
Thanks. Both functions working now

Caveats:
- Time is enabled by default. Date is not, have to manually enable.
- Requires reboot after ticking/unticking to take effect (maybe only on my phone, or maybe others too)

Works great in the end nevertheless.

Edit:
Took a look at the source, everything looks good. I suppose that hook can only be released by a reboot. SharedPreference.OnSharedPreferenceChangeListener might change but didn't commit until next hook (reboot). Ok, I'm a *very* satisfied customer
10th December 2014, 07:03 PM |#9  
OP Senior Member
Flag Linz
Thanks Meter: 82
 
Donate to Me
More
I'm glad it works for you.
Post Reply Subscribe to Thread

Guest Quick Reply (no urls or BBcode)
Message:
Previous Thread Next Thread
Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes