FORUMS
Remove All Ads from XDA

[MOD][Xposed] XGPM - Google Play Music mods

2,142 posts
Thanks Meter: 3,261
 
Post Reply Email Thread
19th April 2015, 08:29 AM |#21  
berryman13's Avatar
Senior Member
Flag San Francisco
Thanks Meter: 1,246
 
Donate to Me
More
Going to try this on a 5.1 Bliss pop 3.1 nightly that I've been maintaining myself for a month now, LG G2 (D800) if you're I interested.
19th April 2015, 12:05 PM |#22  
Senior Member
Thanks Meter: 13
 
More
Pressing the equalizer button crashes GPM. Am I missing something?
19th April 2015, 02:05 PM |#23  
Maxr1998's Avatar
OP Recognized Developer
Flag Augsburg, Germany
Thanks Meter: 3,261
 
Donate to Me
More
Quote:
Originally Posted by sudaltsov

Pressing the equalizer button crashes GPM. Am I missing something?

I believe you need to have an external sound settings app on your device like DSP manager or Viper4Android, probably when it has to use the GPM integrated one it will crash.. Send me a stacktrace please.

Sent using my nexus⁴ running Euphoria 1.0 with Xposed and hells-Core B69-t4 L
Bitcoin donation address
The Following User Says Thank You to Maxr1998 For This Useful Post: [ View ]
19th April 2015, 02:50 PM |#24  
Senior Member
127.0.0.1
Thanks Meter: 424
 
More
This mod works good.. You can implement hiding the app icon from launcher as once anyone changes the settings, it's not much to change many times unless there is a new functionality which will be visible in the changelog.
19th April 2015, 03:39 PM |#25  
Senior Member
Thanks Meter: 13
 
More
Quote:
Originally Posted by Maxr1998

I believe you need to have an external sound settings app on your device like DSP manager or Viper4Android, probably when it has to use the GPM integrated one it will crash.. Send me a stacktrace please.

Sent using my nexus⁴ running Euphoria 1.0 with Xposed and hells-Core B69-t4 L
Bitcoin donation address

I installed dsp manager lite. Still crashes.

---------- Post added at 02:39 PM ---------- Previous post was at 02:33 PM ----------

PS Actually installing Equalizer helps! But I guess the error handling should be improved
19th April 2015, 04:15 PM |#26  
Maxr1998's Avatar
OP Recognized Developer
Flag Augsburg, Germany
Thanks Meter: 3,261
 
Donate to Me
More
Quote:
Originally Posted by sudaltsov

I installed dsp manager lite. Still crashes.



---------- Post added at 02:39 PM ---------- Previous post was at 02:33 PM ----------

PS Actually installing Equalizer helps! But I guess the error handling should be improved

Thanks for the logs! I guess I will put the activity start in a try/catch block to throw a Toast "No equalizer app found!" and disable the button on error.

Sent using my nexus⁴ running Euphoria 1.0 with Xposed and hells-Core B69-t4 L
Bitcoin donation address
The Following User Says Thank You to Maxr1998 For This Useful Post: [ View ]
19th April 2015, 04:15 PM |#27  
Maxr1998's Avatar
OP Recognized Developer
Flag Augsburg, Germany
Thanks Meter: 3,261
 
Donate to Me
More
Quote:
Originally Posted by madman

This mod works good.. You can implement hiding the app icon from launcher as once anyone changes the settings, it's not much to change many times unless there is a new functionality which will be visible in the changelog.

Will do.

Sent using my nexus⁴ running Euphoria 1.0 with Xposed and hells-Core B69-t4 L
Bitcoin donation address
20th April 2015, 09:15 AM |#28  
dstruct2k's Avatar
Senior Member
Flag Winnipeg
Thanks Meter: 940
 
Donate to Me
More
Nonfunctional on Lollipop 5.1 running Google Play Music v5.8.1836R.1787745
Nothing shows in the xposed log, but logcat shows:
Code:
build.board: MSM8974
build.bootloader: G900W8VLU1ANF4
build.brand: samsung
build.cpu_abi: armeabi-v7a
build.cpu_abi2: armeabi
build.device: kltecan
build.display: cm_klte-userdebug 5.1 LMY47I 6c929bc586 test-keys
build.fingerprint: samsung/kltevl/kltecan:4.3/JSS15J/N900W8VLUBMJ4:user/release-keys
build.hardware: qcom
build.host: chronic-buildbox
build.id: LMY47I
build.manufacturer: samsung
build.model: SM-G900W8
build.product: cm_klte
build.radio: unknown
build.serial: cfca9b38
build.tags: test-keys
build.time: 1428300217000
build.type: userdebug
build.user: albinoman887
version.codename: REL
version.incremental: 6c929bc586
version.release: 5.1
version.sdk_int: 22

04-20 02:11:08.470 E/AndroidRuntime(9716): FATAL EXCEPTION: main
04-20 02:11:08.470 E/AndroidRuntime(9716): Process: com.google.android.music:ui, PID: 9716
04-20 02:11:08.470 E/AndroidRuntime(9716): java.lang.RuntimeException: Unable to resume activity {com.google.android.music/com.android.music.activitymanagement.TopLevelActivity}: java.lang.IllegalArgumentException: Wrong number of arguments; expected 3, got 1
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at android.app.ActivityThread.performResumeActivity(ActivityThread.java:3020)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:3051)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2426)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at android.app.ActivityThread.access$900(ActivityThread.java:154)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1324)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at android.os.Handler.dispatchMessage(Handler.java:102)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at android.os.Looper.loop(Looper.java:135)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at android.app.ActivityThread.main(ActivityThread.java:5329)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at java.lang.reflect.Method.invoke(Native Method)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at java.lang.reflect.Method.invoke(Method.java:372)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:904)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:699)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:117)
04-20 02:11:08.470 E/AndroidRuntime(9716): Caused by: java.lang.IllegalArgumentException: Wrong number of arguments; expected 3, got 1
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at de.robv.android.xposed.XposedBridge.invokeOriginalMethodNative(Native Method)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at de.robv.android.xposed.XposedBridge.handleHookedMethod(XposedBridge.java:656)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at com.google.android.music.ui.NowPlayingScreenFragment.<runtime internal resolution method>(Unknown Source)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at com.google.android.music.widgets.ExpandingScrollView.addListener(ExpandingScrollView.java:838)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at com.google.android.music.ui.NowPlayingScreenFragment.onResume(NowPlayingScreenFragment.java:490)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at android.support.v4.app.Fragment.performResume(Fragment.java:1832)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:995)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1138)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1120)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at android.support.v4.app.FragmentManagerImpl.dispatchResume(FragmentManager.java:1939)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at android.support.v4.app.FragmentActivity.onResumeFragments(FragmentActivity.java:447)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at android.support.v4.app.FragmentActivity.onPostResume(FragmentActivity.java:436)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at android.support.v7.app.AppCompatActivity.onPostResume(AppCompatActivity.java:138)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at android.app.Activity.performResume(Activity.java:6089)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at android.app.ActivityThread.performResumeActivity(ActivityThread.java:3009)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	... 12 more
20th April 2015, 03:07 PM |#29  
Maxr1998's Avatar
OP Recognized Developer
Flag Augsburg, Germany
Thanks Meter: 3,261
 
Donate to Me
More
Quote:
Originally Posted by dstruct2k

Nonfunctional on Lollipop 5.1 running Google Play Music v5.8.1836R.1787745
Nothing shows in the xposed log, but logcat shows:

Code:
04-20 02:11:08.470 E/AndroidRuntime(9716): FATAL EXCEPTION: main
04-20 02:11:08.470 E/AndroidRuntime(9716): Process: com.google.android.music:ui, PID: 9716
04-20 02:11:08.470 E/AndroidRuntime(9716): java.lang.RuntimeException: Unable to resume activity {com.google.android.music/com.android.music.activitymanagement.TopLevelActivity}: java.lang.IllegalArgumentException: Wrong number of arguments; expected 3, got 1
04-20 02:11:08.470 E/AndroidRuntime(9716): Caused by: java.lang.IllegalArgumentException: Wrong number of arguments; expected 3, got 1
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at de.robv.android.xposed.XposedBridge.invokeOriginalMethodNative(Native Method)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at de.robv.android.xposed.XposedBridge.handleHookedMethod(XposedBridge.java:656)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at com.google.android.music.ui.NowPlayingScreenFragment.<runtime internal resolution method>(Unknown Source)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at com.google.android.music.widgets.ExpandingScrollView.addListener(ExpandingScrollView.java:838)
04-20 02:11:08.470 E/AndroidRuntime(9716): 	at com.google.android.music.ui.NowPlayingScreenFragment.onResume(NowPlayingScreenFragment.java:490)

This doesn't seem like a issue of the module.. Maybe a Xposed bug on 5.1? I am hooking a method which refers to the ExpandingScrollView, but I don't edit anything in it, I only obtain a object field..
Anyone else having this issue on 5.1?
22nd April 2015, 01:48 AM |#31  
Robot Ross's Avatar
Member
Flag Bournemouth
Thanks Meter: 19
 
More
@Maxr1998 Yeah, I'm having that, causes an instant crash when opening gpm
Post Reply Subscribe to Thread

Tags
google play music, music, xposed

Guest Quick Reply (no urls or BBcode)
Message:
Previous Thread Next Thread
Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes